Indexes and Rollup_Join Docs Added #186
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added documentation for indexes and rollup_join and updated everything according to Tom’s feedback. There’s one intentional deviation: in the index example, the pre-aggregation includes the dimensions id and name. You had suggested keeping only size, but I decided to retain name because it seemed more meaningful for the example, and I kept id since it’s used in the join with orders in the rollup_join section below. That’s also why the index is created on id. So we can saw its pre-aggregated at id,name level.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tagspace
requested changes
Nov 12, 2025
Member
tagspace
left a comment
tagspace
left a comment
There was a problem hiding this comment.
Sorry @Nauman1011 I can't approve this change, for the same reason I described last time: your index example is not a pre-aggregation. It is a complete copy of the data from the database into Cube store. There is no "aggregation" happening. Just copy.
This is, in my opinion, very bad practice, and we shouldn't encourage it through such examples in our documentation.
Let's discuss on a call, if helpful.
Contributor
Author
|
Sure lets connect whenever you are available to discuss this. |
- Updated the indexes section by only using name as a dimension to simplify. Also removed refresh_key as that was unnecessary. - The pre-aggregation i wanted in rollup_join specifically from products model i added that within that specific section so the end user doesn't get confused while only reviewing indexes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added documentation for indexes and rollup_join and updated everything according to Tom’s feedback.
There’s one intentional deviation: in the index example, the pre-aggregation includes the dimensions id and name. You had suggested keeping only size, but I decided to retain name because it seemed more meaningful for the example, and I kept id since it’s used in the join with orders in the rollup_join section below. That’s also why the index is created on id. So we can saw its pre-aggregated at id,name level.