Fixes #51. Copy expanded-tab before propertizing. #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an alternative way to avoid the duplication of overlay images.
I created this alternative branch for the case that you are concerned about any performance impact that
make-string
could possibly cause.The function remains exactly the same as long as
expanded-string
is not propertized with adisplay
property.If it is propertized then the string from
htmlize-tab-spaces
whichexpanded-tab
points to is first copied and then the copy is propertized. This wayhtmlize-tab-spaces
also remains untouched.I find this branch slightly uglier than 51-remove-htmlize-tab-spaces because the resulting code is somewhat more complicated.
But, on the other hand this branch has only minimal changes that just fix the problem and do not change the timing characteristics of the package otherwise. I think it can safely be assumed that display-propertized indentation rarely occurs.