lsp: Add support for external document show (showDocument param :external?) #4872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enhances lsp--window-show-document to handle external URLs by: - Adding external? parameter support from ShowDocumentParams - Opening external URIs in browser via browse-url - Maintaining existing file-based document handling
|
This is useful for gopls web-based features (https://go.dev/gopls/features/web)
|
jcs090218
reviewed
Sep 7, 2025
| (with-current-buffer (find-file path) | ||
| (when selection? | ||
| (goto-char (lsp--position-to-point (lsp:range-start selection?)))) | ||
| t))))) |
There was a problem hiding this comment.
It looks like the indentation is a bit off here. 🤔 Can you fix this for us? Thanks!
There was a problem hiding this comment.
Hi, thanks for your review, it seems github's issue mabye, it looks just ok in my emacs, and my git diff shows that the indentation is ok (I also just checkout this PR locally, it seems normal)
There was a problem hiding this comment.
Ok, sorry, I find there is a 'tab' before "(with-current-buffer ..." in my code (my emacs's electric-indent-mode messed it up), which should be a whitespace , thanks for your fix
jcs090218
approved these changes
Sep 9, 2025
jcs090218
approved these changes
Sep 9, 2025
|
Thank you for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enhances lsp--window-show-document to handle external URLs by:
external?parameter support from ShowDocumentParams