Skip to content

fix argument ref in (dap--create-session) #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix argument ref in (dap--create-session) #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dap-codelldb.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ With prefix, FORCED to redownload the extension."
(lambda (conf)
(let ((debug-port (dap--find-available-port)))
(plist-put conf :program-to-start (format "%s --port %s" dap-codelldb-debug-program debug-port))
(plist-put conf :debugServer debug-port))
(plist-put conf :debugPort debug-port))
(plist-put conf :host "localhost")
(plist-put conf :type "lldb")
(plist-put conf :cargo "")
Expand Down
2 changes: 1 addition & 1 deletion dap-mode.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,7 +1182,7 @@ ADAPTER-ID the id of the adapter."

(defun dap--create-session (launch-args)
"Create debug session from LAUNCH-ARGS."
(-let* (((&plist :host :dap-server-path :name session-name :debugServer port) launch-args)
(-let* (((&plist :host :dap-server-path :name session-name :debugPort port) launch-args)
(proc (if dap-server-path
(make-process
:name session-name
Expand Down
4 changes: 2 additions & 2 deletions dap-python.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ strings, for the sake of launch.json feature parity."
(if module (concat " -m " (shell-quote-argument module)) "")
(if program (shell-quote-argument program) "")
(if (not (string-empty-p python-args)) (concat " " python-args) "")))
(plist-put conf :debugServer debug-port)
(plist-put conf :debugPort debug-port)
(plist-put conf :port debug-port)
(plist-put conf :hostName host)
(plist-put conf :host host)))
Expand Down Expand Up @@ -244,7 +244,7 @@ strings, for the sake of launch.json feature parity."
(host (or (plist-get connect :host) "localhost"))
(port (or (plist-get connect :port) 5678)))
(plist-put conf :host host)
(plist-put conf :debugServer port)
(plist-put conf :debugPort port)
(cl-remf conf :connect)))))

(_ (error "`dap-python': unknown :debugger type %S" debugger)))
Expand Down