Add close/1 #81
Merged
Add close/1 #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
force-pushed
the
close
branch
3 times, most recently
from
981e9a0 to
7d09c8a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 83.88% 84.75% +0.87%
==========================================
Files 25 25
Lines 1837 1870 +33
==========================================
+ Hits 1541 1585 +44
+ Misses 296 285 -11
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Karolk99
approved these changes
Jun 12, 2025
lib/ex_ice/priv/ice_agent.ex
Outdated
| @@ -455,7 +462,7 @@ defmodule ExICE.Priv.ICEAgent do | |||
| end | |||
|
|
|||
| @spec end_of_candidates(t()) :: t() | |||
| def end_of_candidates(%__MODULE__{state: :failed} = ice_agent) do | |||
| def end_of_candidates(%__MODULE__{state: state} = ice_agent) when state in [:failed, :closed] do | |||
| Logger.debug("Can't set end-of-candidates flag in state failed. Ignoring.") | |||
There was a problem hiding this comment.
Suggested change
| Logger.debug("Can't set end-of-candidates flag in state failed. Ignoring.") | |
| Logger.debug("Can't set end-of-candidates flag in state #{state}. Ignoring.") |
test/priv/ice_agent_test.exs
Outdated
There was a problem hiding this comment.
I would ask a test that checks if all public functions in the ice agent won't change state if :closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
close/1function.This function irreversibly closes ICE agent but does not terminate its process. Later calls to getters (e.g.
get_stats/1) are still allowed but the agent can no longer be used to establish a connection.NOTE The best solution would be to modify ICE agent API to be similar to Erlang's :gen_udp API where, after closing a socket,
:gen_udpfunctions return{:error, :closed}tuple. This however, would require a lot of changes. Other incorrect actions e.g. setting remote credentials in a wrong state, are also ignored i.e. no error is returned. If we find this problematic, we will modify ICE agent API in the future.Related to: elixir-webrtc/ex_webrtc#218