Allow optional context in on_exit callbacks.#15496
Open
christhekeele wants to merge 2 commits into
Open
Conversation
4cc3f16 to
f60d9cf
Compare
christhekeele
commented
Jun 16, 2026
f60d9cf to
1f876a1
Compare
1f876a1 to
5fe6af8
Compare
sabiwara
reviewed
Jun 16, 2026
sabiwara
reviewed
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #elixir-lang-core discussion, this PR allows
ExUnit.Callbacks.on_exit/2to be given acallbackfunction that accepts an argument. This argument can be used to perform conditional cleanup based on test results.In the discussion I proposed that this argument be an
ExUnit.state(). In this implementation, however, I decided to allow it to be the full%ExUnit.Test{} | %ExUnit.TestModule{}struct, under the reasoning that:ExUnit.state()is for an%ExUnit.TestModule{}is somewhat unclearnil, and when passed along to a callback it loses context as to if asetup/1test passed, or the callback was provided insetup_all/1test.stateortest_module.namealong, and am still open to this approachsetup/1vssetup_all/1statusin the future, the conditional cleanup we can do becomes more powerful%ExUnit.Test{time: time_in_ms}to change how it does cleanup