Skip to content

(fix) #31 Don't crash on download failures #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leonardb wants to merge 2 commits into
base: master
Choose a base branch
from
Open

(fix) #31 Don't crash on download failures #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab0bcbb
(fix) #31 Don't crash on download failures
kyle-neal Jun 29, 2023
422b629
Merge branch 'elixir-inspector:master' into fix/31/def-download-crash
leonardb Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/ua_inspector/downloader.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ defmodule UAInspector.Downloader do
alias UAInspector.Downloader.ShortCodeMapConverter
alias UAInspector.ShortCodeMap

require Logger

@client_hints [
ClientHints.Apps,
ClientHints.Browsers
Expand Down Expand Up @@ -106,8 +108,14 @@ defmodule UAInspector.Downloader do
end

defp download_file(remote, local) do
{:ok, content} = Config.downloader_adapter().read_remote(remote)

File.write!(local, content)
case Config.downloader_adapter().read_remote(remote) do
{:ok, content} ->
File.write!(local, content)
:ok

{:error, reason} ->
Logger.error("Failed to download file: #{reason}")
:ok
end
end
end