Conversation
* Update cancer_data.md main text edits to insert the Minimal set for cancer * Update pages/your_domain/cancer_data.md thanks for suggestion Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com> * Update pages/your_domain/cancer_data.md Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com> * Update pages/your_domain/cancer_data.md Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com> * Update pages/your_domain/cancer_data.md Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com> * Update pages/your_domain/cancer_data.md Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com> * Update pages/your_domain/cancer_data.md Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com> --------- Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>
Added reference to The Minimal Dataset for Cancer of the 1+ Million Genomes in the reference file
Addition of my records in the contributors file
* Update cancer_data.md Change in Introduction to include the concept of data model for cancer and standard formats * Update Riba et al. citation --------- Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
|
@MichelaRiba I have combined all your changes in this PR. Could you double check if they are the way you want them to be? @bianchini88 I guess we still have to add a reference in the text itself? |
|
Hi,
Thanks.
I have gone through cancer data-dev branch and think this is fine. Sorry for mixing up.
Don’t know if since the FAIRsharing record has changed status into approved, we are supposed to update this GitHub when a DOi and amendments there have been done.
Michela
… On 12 Mar 2026, at 16:34, Bert Droesbeke ***@***.***> wrote:
bedroesb
left a comment
(elixir-europe/rdmkit#1809)
<#1809 (comment)>
@MichelaRiba <https://github.com/MichelaRiba> I have combined all your changes in this PR. Could you double check if they are the way you want them to be? @bianchini88 <https://github.com/bianchini88> I guess we still have to add a reference in the text itself?
—
Reply to this email directly, view it on GitHub <#1809 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A7SX6YZU57U4EYEDC4OIDVT4QLKHFAVCNFSM6AAAAACWPR34R2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANBXG4ZTIOBVHE>.
You are receiving this because you were mentioned.
|
|
@MichelaRiba No problem! @bianchini88 do you know more about this fairsharing record? |
|
Hi @bedroesb and @MichelaRiba.
The record is approved and awaiting a DOI (https://fairsharing.org/7812). If we merge this (quite likely) before the entry gets a DOI, I will open an issue and edit the page when the time comes; no need for @MichelaRiba to come back to fix it. @MichelaRiba, for clarity, Bert did merge your PRs, but now this PR is from a branch of this repository and not from your fork. I could not perform this operation on your fork, as I do not have collaborator privileges there. I will proceed with the review on this PR as time allows. I remember the citation of the bibliography entry was not actually present. |
|
Hi,
concerning the refrence I have updated in the last days as mentioned and I can see that it is recorded in the following branch.
https://github.com/elixir-europe/rdmkit/blob/cancerdata-dev/_bibliography/references.bib
Do you think it is still problematic, please tell me. I have exported from Mendeley this time
Thanks a lot
Michela
… On 16 Mar 2026, at 09:22, Federico Bianchini ***@***.***> wrote:
bianchini88
left a comment
(elixir-europe/rdmkit#1809)
<#1809 (comment)>
Hi @bedroesb <https://github.com/bedroesb> and @MichelaRiba <https://github.com/MichelaRiba>.
do you know more about this fairsharing record?
The record is approved and awaiting a DOI (https://fairsharing.org/7812). If we merge this (quite likely) before the entry gets a DOI, I will open an issue and edit the page when the time comes; no need for @MichelaRiba <https://github.com/MichelaRiba> to come back to fix it.
@MichelaRiba <https://github.com/MichelaRiba>, for clarity, Bert did merge your PRs, but now this PR is from a branch of this repository and not from your fork. I could not perform this operation on your fork, as I do not have collaborator privileges there.
I will proceed with the review on this PR as time allows. I remember the citation of the bibliography entry was not actually present.
—
Reply to this email directly, view it on GitHub <#1809 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A7SX6Y6L2ARDOIQXNKOY6734Q62TTAVCNFSM6AAAAACWPR34R2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANRVHEYDAMRVHE>.
You are receiving this because you were mentioned.
|
|
@MichelaRiba, I will deploy locally as part of the review and verify if the entry looks ok. I was mostly referring above to the lack of a bibliography section on the page and to the missing citation tag (see https://rdmkit.elixir-europe.org/style_guide#bibliography), but I will add these myself as part of the review. |
|
Hi Federico,
thanks a lot
Michela
… On 16 Mar 2026, at 12:28, Federico Bianchini ***@***.***> wrote:
bianchini88
left a comment
(elixir-europe/rdmkit#1809)
<#1809 (comment)>
@MichelaRiba <https://github.com/MichelaRiba>, I will deploy locally as part of the review and verify if the entry looks ok.
I was mostly referring above to the lack of a bibliography section on the page and to the missing citation tag (see https://rdmkit.elixir-europe.org/style_guide#bibliography), but I will add these myself as part of the review.
—
Reply to this email directly, view it on GitHub <#1809 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A7SX6Y2BDJOHK6JXE3CCORD4Q7QOJAVCNFSM6AAAAACWPR34R2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANRWHE4DKMRUGI>.
You are receiving this because you were mentioned.
|
Fixed conflict
fixing conflicts
removing special characters Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>
Grammar and style improvements
|
@MichelaRiba Approved by me. Let's give the other editors time to comment before merging. |
|
Grazie mille
Michela
… On 17 Mar 2026, at 15:49, Federico Bianchini ***@***.***> wrote:
bianchini88
left a comment
(elixir-europe/rdmkit#1809)
<#1809 (comment)>
@MichelaRiba <https://github.com/MichelaRiba> Approved by me. Let's give the other editors time to comment before merging.
—
Reply to this email directly, view it on GitHub <#1809 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A7SX6Y6EIRK4E2SMZ7CPWYL4RFQWZAVCNFSM6AAAAACWPR34R2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANZVGU2DQNZXGY>.
You are receiving this because you were mentioned.
|
Co-authored-by: Gil Poiares-Oliveira <gil.oliveira@tecnico.ulisboa.pt>
Co-authored-by: Gil Poiares-Oliveira <gil.oliveira@tecnico.ulisboa.pt>
Co-authored-by: Gil Poiares-Oliveira <gil.oliveira@tecnico.ulisboa.pt>
No description provided.