Skip to content

Combined Cancer data page changes#1809

Open
bedroesb wants to merge 15 commits intomasterfrom
cancerdata-dev
Open

Combined Cancer data page changes#1809
bedroesb wants to merge 15 commits intomasterfrom
cancerdata-dev

Conversation

@bedroesb
Copy link
Member

No description provided.

MichelaRiba and others added 3 commits March 12, 2026 12:26
* Update cancer_data.md

main text edits to insert the Minimal set for cancer

* Update pages/your_domain/cancer_data.md

thanks for suggestion

Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>

* Update pages/your_domain/cancer_data.md

Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>

* Update pages/your_domain/cancer_data.md

Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>

* Update pages/your_domain/cancer_data.md

Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>

* Update pages/your_domain/cancer_data.md

Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>

* Update pages/your_domain/cancer_data.md

Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>

---------

Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>
Added reference to The Minimal Dataset for Cancer of the 1+ Million Genomes in the reference file
Addition of my records in the contributors file
* Update cancer_data.md

Change in Introduction to include the concept of data model for cancer and standard formats

* Update Riba et al. citation

---------

Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
@bedroesb
Copy link
Member Author

@MichelaRiba I have combined all your changes in this PR. Could you double check if they are the way you want them to be? @bianchini88 I guess we still have to add a reference in the text itself?

@MichelaRiba
Copy link

MichelaRiba commented Mar 12, 2026 via email

@bedroesb
Copy link
Member Author

@MichelaRiba No problem! @bianchini88 do you know more about this fairsharing record?

@bianchini88
Copy link
Collaborator

Hi @bedroesb and @MichelaRiba.

do you know more about this fairsharing record?

The record is approved and awaiting a DOI (https://fairsharing.org/7812). If we merge this (quite likely) before the entry gets a DOI, I will open an issue and edit the page when the time comes; no need for @MichelaRiba to come back to fix it.

@MichelaRiba, for clarity, Bert did merge your PRs, but now this PR is from a branch of this repository and not from your fork. I could not perform this operation on your fork, as I do not have collaborator privileges there.

I will proceed with the review on this PR as time allows. I remember the citation of the bibliography entry was not actually present.

@MichelaRiba
Copy link

MichelaRiba commented Mar 16, 2026 via email

@bianchini88
Copy link
Collaborator

@MichelaRiba, I will deploy locally as part of the review and verify if the entry looks ok.

I was mostly referring above to the lack of a bibliography section on the page and to the missing citation tag (see https://rdmkit.elixir-europe.org/style_guide#bibliography), but I will add these myself as part of the review.

@MichelaRiba
Copy link

MichelaRiba commented Mar 16, 2026 via email

@bianchini88 bianchini88 requested a review from wittigue as a code owner March 17, 2026 13:27
removing special characters

Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>
Grammar and style improvements
@bianchini88 bianchini88 self-requested a review March 17, 2026 14:47
@bianchini88
Copy link
Collaborator

@MichelaRiba Approved by me. Let's give the other editors time to comment before merging.

@MichelaRiba
Copy link

MichelaRiba commented Mar 17, 2026 via email

bianchini88 and others added 3 commits March 17, 2026 21:05
Co-authored-by: Gil Poiares-Oliveira <gil.oliveira@tecnico.ulisboa.pt>
Co-authored-by: Gil Poiares-Oliveira <gil.oliveira@tecnico.ulisboa.pt>
Co-authored-by: Gil Poiares-Oliveira <gil.oliveira@tecnico.ulisboa.pt>
@bianchini88 bianchini88 requested a review from GilOliveira March 17, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants