Add safe LOCAL INFILE support - #215
Open
iagocavalcante wants to merge 1 commit into
Open
iagocavalcante wants to merge 1 commit into
iagocavalcante wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:local_infilefile path for text queriesCLIENT_LOCAL_FILESand decode the0xFBfilename as an EOF stringSecurity
A MySQL server can request a different client-side path from the one named in the SQL statement. To avoid arbitrary file disclosure, this implementation ignores the server-provided filename and requires callers to pass an explicit path for each query:
This supersedes #204 and follows the safe, explicit-source direction discussed in #110.
Testing
mix compile --warnings-as-errorsmix test --exclude requires_otp_19against MySQL 8.4Closes #203