Skip to content

Fix open-folder shortcut #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix open-folder shortcut #1640

wants to merge 3 commits into from

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Aug 12, 2025 •
edited
Loading

  • Resolve shortcut conflict
  • Add target to open-folder shortcut

@jeremypw jeremypw mentioned this pull request Aug 12, 2025
Open
@jeremypw jeremypw marked this pull request as ready for review August 13, 2025 10:53
lenemter
lenemter requested changes Aug 18, 2025
View reviewed changes
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the accelerator in the menu..?

master:

image

This branch:

image

@jeremypw
Copy link
Collaborator Author

jeremypw commented Aug 18, 2025 •
edited
Loading

Hmm, looks like I got confused with which version was running again 😞 Just tried again and the menu accel is gone. However, I think it worth fixing that separately from actually getting the accel to work (see @danirabbit comments on previous attempt (#1626))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenemter lenemter lenemter requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremypw @lenemter