-
-
Notifications
You must be signed in to change notification settings - Fork 113
Handle closing second or subsequent window #1620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I don't think moving unsaved files from window A to window B is expected behaviour at all. I don't like this behaviour. Window B should: A) Autosave all files from the window that are unsaved. B) Ask to save them (I think this is discouraged by elementary guidelines, but it might make sense in this specific context where the user closes the window with unsaved files?) |
Yeah I agree I don't think this is the expected behavior. If I'm closing a window with tabs, I would expect those tabs to close. If I wanted to keep the tabs, I'd move them to the other window. There seems to be a couple of issues in #721:
|
@danirabbit @kaixoo12 Thanks for the input - I'll rework this PR accordingly. Note that with the suggested behaviour, the documents will be saved but not restored. |
@danirabbit I think |
Note: The PR currently restores the doc in the last closed window, not the first opened window. Please confirm whether this is the correct behaviour. |
Fixes #721
When a second or subsequent window is closed its documents are just closed after saving if required.
Closing a second or subsequent window (with
<Alt>F4
or otherwise) only closes the focused window.<Ctrl>Q
closes all windows. Only the docs in the last closed window will be restored.NOTE: Restarting or closing down the system still causes unsaved data to be lost as in 'master'.
Some names are changed to make clearer their function.