Skip to content

Highlight selection plugin: Fix highlighting when same word reselected #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Highlight selection plugin: Fix highlighting when same word reselected #1582

wants to merge 4 commits into from

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented May 29, 2025 •
edited
Loading

#1520

  • Simplify workings following recent changes to master
  • selection-changed signal replaced with selection-event signal (SearchBar no longer listens to original signal)
  • Separate deselected signal no longer required
  • Anonymous closure used to handle throttled selection-event signal

TODO

  • Fix behaviour when search is on going

@jeremypw
Copy link
Collaborator Author

Works OK without ongoing search but regression in draw-spaces when there is a search term in the search bar. Further work required.

@jeremypw jeremypw added the Status: Blocked Something else needs to be done before this can be fixed label Jul 16, 2025
@jeremypw
Copy link
Collaborator Author

Blocking as conflicts with #1622 which needs to be merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Blocked Something else needs to be done before this can be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeremypw