Skip to content

Conversation

N-Pex
Copy link

@N-Pex N-Pex commented Sep 17, 2025

https://spec.matrix.org/latest/client-server-api/#put_matrixclientv3roomsroomidredacteventidtxnid

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@N-Pex N-Pex requested a review from a team as a code owner September 17, 2025 13:22
@CLAassistant
Copy link

CLAassistant commented Sep 17, 2025

CLA assistant check
All committers have signed the CLA.

@reivilibre
Copy link
Contributor

Hm! Not overall keen on disabling rate limiting here, because the rate limiting is there for a reason (essentially to prevent degradation of service by a single user, for example).

Doing some more reading, I'm starting to get the picture that this is more of a spec bug: matrix-org/matrix-spec#584 (comment)
and that servers are allowed to rate-limit whenever they want; the entries in the spec are supposedly 'recommendations'...

@MadLittleMods MadLittleMods removed the request for review from a team September 23, 2025 04:28
@N-Pex
Copy link
Author

N-Pex commented Sep 29, 2025

Yeah, I can understand your hesitation and do see problems with removing the rate limit. But for a use case of "redact all events in a room" by an admin, the rate limit makes it pretty impossible to use from a user perspective... Perhaps there is nowadays a client API way to remove a room, it's been a while since I checked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants