Skip to content

Add configurable allowlist for setting custom profile fields #18562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Jun 17, 2025

Fixes #18525

This PR adds a new config option to the experimental implementation of MSC4133 that forbids users from adding/updating certain profile keys unless that key is on the allowlist. This does not affect setting a user's displayname or avatar URL.

Note: MSC4133 has been accepted, and the implementation should be stabilised. This can happen as a follow-up to this PR though. As the implementation is not stable, no config documentation has been written.

Note: This PR was mostly written by OpenAI Codex, before being reviewed by myself. Commits written by Codex are marked as those made by @anoadragon453-codex. Please use extra caution when reviewing them.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@anoadragon453 anoadragon453 marked this pull request as ready for review June 17, 2025 11:49
@anoadragon453 anoadragon453 requested a review from a team as a code owner June 17, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config to prevent changes to custom profile keys
2 participants