Skip to content

Send full user agent header to server during OIDC authentication and when viewing Account and Device management screens#7997

Merged
pixlwave merged 2 commits intodevelopfrom
hughns/x-element-user-agent
Mar 3, 2026
Merged

Send full user agent header to server during OIDC authentication and when viewing Account and Device management screens#7997
pixlwave merged 2 commits intodevelopfrom
hughns/x-element-user-agent

Conversation

@hughns
Copy link
Member

@hughns hughns commented Jan 12, 2026

This is the equivalent of element-hq/element-x-ios#4106 but in Element Classic.

It allows the home server account management screens to see the full Element User-Agent even when running inside an ASWebAuthenticationSession.

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.57%. Comparing base (acfac7c) to head (c08b257).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...uthentication/SSO/SSOAuthentificationSession.swift 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7997      +/-   ##
===========================================
+ Coverage    15.19%   16.57%   +1.38%     
===========================================
  Files         1815     1815              
  Lines       119414   119420       +6     
  Branches     47786    47787       +1     
===========================================
+ Hits         18143    19795    +1652     
+ Misses      100603    98955    -1648     
- Partials       668      670       +2     
Flag Coverage Δ
uitests 59.68% <ø> (+10.06%) ⬆️
unittests 8.80% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pixlwave pixlwave marked this pull request as ready for review March 3, 2026 09:23
@pixlwave pixlwave force-pushed the hughns/x-element-user-agent branch from 8d7a352 to c08b257 Compare March 3, 2026 09:23
@pixlwave pixlwave merged commit 3479406 into develop Mar 3, 2026
7 of 8 checks passed
@pixlwave pixlwave deleted the hughns/x-element-user-agent branch March 3, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants