-
Notifications
You must be signed in to change notification settings - Fork 116
Migrate Elasticsearch role mapping resource and data source to Plugin Framework #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished work on behalf of
tobio
September 5, 2025 04:35
This comment was marked as outdated.
This comment was marked as outdated.
…s, use framework diagnostics, and cleanup Co-authored-by: tobio <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Copilot finished work on behalf of
tobio
September 5, 2025 06:19
…ized JSON types to data source Co-authored-by: tobio <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Copilot finished work on behalf of
tobio
September 5, 2025 10:09
…or role handling Co-authored-by: tobio <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Copilot finished work on behalf of
tobio
September 5, 2025 10:41
tobio
approved these changes
Sep 5, 2025
nick-benoit
approved these changes
Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the
elasticstack_elasticsearch_security_role_mapping
resource and data source from the legacy Terraform SDKv2 to the modern Terraform Plugin Framework, bringing consistency with other recently migrated resources likesystem_user
andenrich_policy
.Changes Made
New Plugin Framework Implementation
internal/elasticsearch/security/role_mapping/
following the established code organization patternjsontypes.NormalizedType{}
forrules
,role_templates
, andmetadata
fields to suppress insignificant formatting differencesKey Features Preserved
roles
androle_templates
with exactly-one-of validationelasticsearch_connection
block supportCode Quality Improvements
readRoleMapping
function returningRoleMappingData
and framework diagnosticsutils.IsKnown()
helperutils.SetValueFrom
andutils.SetTypeAs
for cleaner codeTest Coverage
0.11.17
to ensure smooth migration for existing usersMigration Benefits
The migration maintains 100% backward compatibility - existing Terraform configurations will continue to work without any changes required.
Recent Updates
Fixes #1279.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.