-
Notifications
You must be signed in to change notification settings - Fork 47
feat: multi step api runner #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
shahzad31
wants to merge
7
commits into
main
Choose a base branch
from
api-journey
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
448e6a8
added an api runner
shahzad31 524d141
added an api runner
shahzad31 6e04f85
add interceptor
shahzad31 f28ec2c
bit of clean up
shahzad31 d66a99b
refactor based on feedback
shahzad31 e3f615c
more clarity
shahzad31 30de3d5
update types
shahzad31 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
/** | ||
* MIT License | ||
* | ||
* Copyright (c) 2020-present, Elastic NV | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in | ||
* all copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
* THE SOFTWARE. | ||
* | ||
*/ | ||
|
||
import { request as apiRequest } from 'playwright-core'; | ||
import { log } from './logger'; | ||
import { APIDriver, RunOptions } from '../common_types'; | ||
import { APIPluginManager } from '../plugins/api-plugin-manager'; | ||
|
||
/** | ||
* Purpose of the Gatherer is to set up the necessary browser driver | ||
* related capabilities for the runner to run all journeys | ||
*/ | ||
export class APIGatherer { | ||
static pluginManager: APIPluginManager; | ||
|
||
static async setupDriver(options: RunOptions) { | ||
log('Gatherer: setup browser'); | ||
const { playwrightOptions } = options; | ||
|
||
// Register sig int handler to close the browser | ||
process.on('SIGINT', async () => { | ||
await APIGatherer.stop(); | ||
process.exit(130); | ||
}); | ||
|
||
const request = await apiRequest.newContext({ ...playwrightOptions }); | ||
return { request }; | ||
} | ||
|
||
/** | ||
* Starts recording all events related to the v8 devtools protocol | ||
* https://chromedevtools.github.io/devtools-protocol/v8/ | ||
*/ | ||
|
||
static async beginRecording(driver: APIDriver, options: RunOptions) { | ||
log('Gatherer: started recording'); | ||
APIGatherer.pluginManager = new APIPluginManager(driver); | ||
APIGatherer.pluginManager.registerAll(options); | ||
const plugins = []; | ||
plugins.push(await APIGatherer.pluginManager.start('network')); | ||
|
||
await Promise.all(plugins); | ||
return APIGatherer.pluginManager; | ||
} | ||
|
||
static async endRecording() { | ||
log('Gatherer: ended recording'); | ||
await APIGatherer.pluginManager.unregisterAll(); | ||
} | ||
|
||
static async dispose(driver: APIDriver) { | ||
log(`Gatherer: closing all contexts`); | ||
await driver.request.dispose(); | ||
} | ||
|
||
static async stop() { | ||
log(`Gatherer: closing browser`); | ||
// if (Gatherer.request) { | ||
// await Gatherer.browser.close(); | ||
// Gatherer.browser = null; | ||
// } | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
browserDelay is not appropriate for apijourneys?