-
Notifications
You must be signed in to change notification settings - Fork 65
[ML] Report the "actual" memory usage of the autodetect process #2846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edsavage
wants to merge
24
commits into
elastic:main
Choose a base branch
from
edsavage:ad_real_mem_usage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a7b1ce2
[ML] Report the "actual" memory usage of the autodetect process
edsavage cb957ca
Update changelog
edsavage 8f73f02
Formatting
edsavage d3a39ae
Appease SonarQube
edsavage e2d1bf5
Tweak unit test for platform portability
edsavage 1a9a99a
Attend to review comments
edsavage 5ae22cb
Update bin/autodetect/Main.cc
edsavage fe6f1fa
Update include/model/CResourceMonitor.h
edsavage 582430e
Update include/model/CResourceMonitor.h
edsavage 9476ede
Attend to review comments
edsavage e29d8f7
Merge remote-tracking branch 'origin/ad_real_mem_usage' into ad_real_…
edsavage 475fef1
Formatting
edsavage fc8888c
Merge branch 'main' of github.com:elastic/ml-cpp into ad_real_mem_usage
edsavage 6945d3f
Attend to failing unit tests (hopefully)
edsavage 3b69b72
Formatting.. grr
edsavage 1bafa8c
On Linux only, use the value of the system memory usage (max resident…
edsavage efc311b
Fix copyright headers
edsavage 6be6395
Nits in test code
edsavage 134a494
Attend to code review comments
edsavage ed426ac
Formatting
edsavage 4c8bf8b
Attend to code review comments
edsavage fa9c4fa
Small tidy up of CProcessMemoryUsage.cc
edsavage 014be1c
Small tidy up
edsavage 41c02de
On Linux, return system memory (max resident set size) from CResource…
edsavage File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ | |
#include <core/CProcessStats.h> | ||
|
||
#include <core/CLogger.h> | ||
#include <core/CProgramCounters.h> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this include used here? |
||
#include <core/CStringUtils.h> | ||
|
||
#include <errno.h> | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,9 +8,11 @@ | |
* compliance with the Elastic License 2.0 and the foregoing additional | ||
* limitation. | ||
*/ | ||
#include <core/CLogger.h> | ||
#include <core/CProcessStats.h> | ||
|
||
#include <core/CLogger.h> | ||
#include <core/CProgramCounters.h> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are these included needed here? |
||
|
||
#include <errno.h> | ||
#include <fcntl.h> | ||
#include <sys/resource.h> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICS, this keys are not used anymore.