Skip to content

auto generated docs for latest plugin versions #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Jan 23, 2018

@dedemorton this is the result of generating the docs for just the latest version of each plugin.

There are still some things I generate differently, mostly due to lack of information like the description.
My thinking is that we (I) should submit doc PR changes for these 11 plugins, and release new versions.
After this we can start relying on auto generation, or at least script-driven generation.

@jsvd jsvd requested a review from dedemorton January 23, 2018 22:21
@dedemorton
Copy link
Contributor

dedemorton commented Jan 23, 2018

@jsvd So is this the full list of changes we need to make to the repos, or is there still some stuff from earlier iterations that needs cleaning up (like the links)?

Even if the script handles converting the link format from internal to external, we might want to update the links in the repos 'cause people have a way of looking at existing stuff for examples. We wouldn't have to make the changes before we publish the doc, tho.

@jsvd
Copy link
Member Author

jsvd commented Jan 24, 2018

Even if the script handles converting the link format from internal to external, we might want to update the links in the repos 'cause people have a way of looking at existing stuff for examples.

++

@dedemorton I'll dial down the corrections I perform automatically and recompute this PR

@jsvd jsvd force-pushed the latest_broken_versioned_docs branch from 7605b7b to fc3d177 Compare January 24, 2018 01:00
@jsvd
Copy link
Member Author

jsvd commented Jan 24, 2018

@dedemorton skipping doc repair heuristics like the data types link conversion we see that 190 plugins need corrections

@dedemorton
Copy link
Contributor

@jsvd Is that all? haha. I'd make the data type conversions an exception, but then...if we do that, we're back to the original problem of people duplicating what they see in the existing dos.

hmmm...so maybe we just leave the doc repair heuristics alone?

@jsvd jsvd force-pushed the latest_broken_versioned_docs branch from fc3d177 to ec45574 Compare January 24, 2018 11:52
@jsvd
Copy link
Member Author

jsvd commented Jan 24, 2018

@dedemorton I recomputed the PR to apply the data type conversions only. This shows 26 plugins whose latest release tag contains "broken" documentation.

I think it's a reasonable goal to:
a) massively apply the data type link conversions to all plugins
b) fix the remaining broken docs for these 26 plugins
c) mass release plugins with doc changes

WDYT?

[edit]

I created an example PR for 1 plugin that addresses only the data type conversions: logstash-plugins/logstash-output-elasticsearch#728

@dedemorton
Copy link
Contributor

I'm going to close this PR. I opened issue #9048 to track the remaining tasks for the versioned plugin reference.

@dedemorton dedemorton closed this Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants