[FireEye] Add missing ECS fields #14550
Open
+203
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moxarth-rathod
added
enhancement
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh
added
the
documentation
andrewkroh
reviewed
Jul 15, 2025
| - set: | ||
| field: event.outcome | ||
| value: success | ||
| if: ctx.rawmsg?.app_proto != null && ['succeded'].contains(ctx.rawmsg.app_proto.toLowerCase()) |
There was a problem hiding this comment.
Is succeded correct? It's not spelled correctly. Do we have a sample showing an example app_proto value that contains the misspelling? It looks like the samples either have failed or the name of a protocol.
packages/fireeye/data_stream/nx/elasticsearch/ingest_pipeline/renaming-raws.yml
Outdated
Show resolved
Hide resolved
| @@ -12,7 +12,20 @@ processors: | |||
| - rename: | |||
| field: rawmsg.app_proto | |||
| target_field: network.protocol | |||
| if: ctx.rawmsg.app_proto != null && !['failed','succeded'].contains(ctx.rawmsg.app_proto.toLowerCase()) | |||
There was a problem hiding this comment.
I think this can be written out as "if foo equals failed || if foo equals succeeded" to avoid allocating a new list in each expression eval.
Co-authored-by: Andrew Kroh <[email protected]>
|
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues