Skip to content

[prometheus_input] Add missing SSL fields to sync it with the Prometheus package #14503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[prometheus_input] Add missing SSL fields to sync it with the Prometheus package #14503

wants to merge 2 commits into from
+59 −1

Conversation

devamanv
Copy link
Contributor

@devamanv devamanv commented Jul 11, 2025 •
edited
Loading

Proposed commit message

The PR contains changes to add SSL related configuration options.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

@andrewkroh andrewkroh added the Integration:prometheus_input Prometheus Input label Jul 11, 2025
@devamanv devamanv added Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] enhancement New feature or request labels Jul 11, 2025
@devamanv devamanv mentioned this pull request Jul 11, 2025
Open
@devamanv devamanv marked this pull request as ready for review July 11, 2025 16:11
@devamanv devamanv requested a review from a team as a code owner July 11, 2025 16:11
gpop63
gpop63 reviewed Jul 14, 2025
View reviewed changes
packages/prometheus_input/agent/input/input.yml.hbs
Comment on lines +29 to +40
{{#if ssl.certificate}}
ssl.certificate: {{ssl.certificate}}
{{/if}}
{{#if ssl.key}}
ssl.key: {{ssl.key}}
{{/if}}
{{#if ssl.key_passphrase}}
ssl.key_passphrase: {{ssl.key_passphrase}}
{{/if}}
{{#if ssl.ca_trusted_fingerprint}}
ssl.ca_trusted_fingerprint: {{ssl.ca_trusted_fingerprint}}
{{/if}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this instead of having all these separate options for the same thing ssl option in UI?

{{#if ssl}}
ssl: {{ssl}}
{{/if}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpop63 gpop63 gpop63 left review comments

@mykola-elastic mykola-elastic mykola-elastic approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request Integration:prometheus_input Prometheus Input Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Prometheus Input]: Expose metricbeat setting to disable SSL verification
5 participants
@devamanv @elasticmachine @gpop63 @mykola-elastic @andrewkroh