[do-not-merge] mysql ci debug #14468
Draft
+61
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes made to fix this error: Got hints from BK logs: |
🚀 Benchmarks reportTo see the full report comment with |
shmsr
commented
Jul 9, 2025
|
|
||
| # Verify slave status | ||
| echo "Verifying slave status..." | ||
| mysql -uroot -p"$MYSQL_ROOT_PASSWORD" -e "GRANT REPLICATION CLIENT ON *.* TO 'mydb_replica_user'@'%'; FLUSH PRIVILEGES;" |
There was a problem hiding this comment.
This is redundant as it is already there in grant-permissions.sql. Also the placement is wrong as GRANTs should be done before starting the slave.
shmsr
commented
Jul 9, 2025
Comment on lines
63
to
90
| mysql -uroot -p"$MYSQL_ROOT_PASSWORD" -e "STOP SLAVE; RESET SLAVE ALL;" 2>/dev/null || echo "Slave was not running" | ||
|
|
||
| # Use here-doc to avoid command line escaping issues | ||
| mysql -uroot -p"$MYSQL_ROOT_PASSWORD" <<EOF | ||
| CHANGE MASTER TO | ||
| MASTER_HOST='$MYSQL_MASTER_HOST', | ||
| MASTER_USER='mydb_replica_user', | ||
| MASTER_PASSWORD='mydb_replica_pwd', | ||
| MASTER_LOG_FILE='$CURRENT_LOG', | ||
| MASTER_LOG_POS=$CURRENT_POS; | ||
| EOF | ||
|
|
||
| # Prepare the CHANGE MASTER TO command | ||
| start_slave_stmt="CHANGE MASTER TO MASTER_HOST='$MYSQL_MASTER_HOST', MASTER_USER='mydb_replica_user', MASTER_PASSWORD='mydb_replica_pwd', MASTER_LOG_FILE='$CURRENT_LOG', MASTER_LOG_POS=$CURRENT_POS; START SLAVE;" | ||
| if [ $? -eq 0 ]; then | ||
| echo "CHANGE MASTER command executed successfully" | ||
|
|
||
| # Display the command that will be executed | ||
| echo "Running the following command to start replication: $start_slave_stmt" | ||
| # Start the slave | ||
| mysql -uroot -p"$MYSQL_ROOT_PASSWORD" -e "START SLAVE;" | ||
|
|
||
| # Run the CHANGE MASTER TO command | ||
| mysql -uroot -p"$MYSQL_ROOT_PASSWORD" -e "$start_slave_stmt" || { | ||
| echo "Failed to start replication. Entering sleep mode for debugging." | ||
| tail -f /dev/null # This will keep the container running indefinitely | ||
| } | ||
| if [ $? -eq 0 ]; then | ||
| echo "Slave started successfully" | ||
| else | ||
| echo "Failed to start slave" | ||
| exit 1 | ||
| fi | ||
| else | ||
| echo "Failed to execute CHANGE MASTER command" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Same thing but better error handling.
shmsr
commented
Jul 9, 2025
Comment on lines
+23
to
+33
| echo "Attempt $i: Checking master status..." | ||
| MS_STATUS=$(mysql -h "$MYSQL_MASTER_HOST" -P 3306 -u root -p"$MYSQL_ROOT_PASSWORD" -e "SHOW MASTER STATUS;" 2>/dev/null || echo "FAILED") | ||
|
|
||
| if [ "$MS_STATUS" = "FAILED" ]; then | ||
| echo "Failed to connect to master, retrying..." | ||
| sleep 2 | ||
| continue | ||
| fi | ||
|
|
||
| echo "Master status response: $MS_STATUS" | ||
|
|
There was a problem hiding this comment.
Again better handling but with 2s delay before retrying.
shmsr
commented
Jul 9, 2025
Comment on lines
+2
to
3
| GRANT REPLICATION SLAVE ON *.* TO 'mydb_replica_user'@'%'; | ||
| GRANT REPLICATION CLIENT ON *.* TO 'mydb_replica_user'@'%'; |
There was a problem hiding this comment.
REPLICATION CLIENT - This allows the user to execute SHOW MASTER STATUS and SHOW SLAVE STATUS commands
GRANT REPLICATION SLAVE - This allows the user to connect as a replica (START SLAVE)
After I fixed, there was one more issue. The previous script was working as of now somehow but it had issues. Now it is much robust than before. |
|
💚 Build Succeeded
History
cc @shmsr |
|
CI passed 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title.
Checklist
changelog.ymlfile.