Skip to content

snyk: add attributes.status and attributes.updated_at field values to fingerprint #14430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

snyk: add attributes.status and attributes.updated_at field values to fingerprint #14430

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
986e898
snyk: add attributes.status and attributes.updated_at field values to…
efd6 Jul 7, 2025
b438e2a
address pr comment
efd6 Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/snyk/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "2.2.0"
changes:
- description: Add `attributes.status` and `attributes.updated_at` field values to fingerprint.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- description: Add `attributes.status` and `attributes.updated_at` field values to fingerprint.
- description: Add `attributes.ignored`, `attributes.status` and `attributes.updated_at` field values to fingerprint.

type: enhancement
link: https://github.com/elastic/integrations/pull/14430
- version: "2.1.0"
changes:
- description: Add maximum executions configuration option for data streams.
Expand Down
3 changes: 3 additions & 0 deletions packages/snyk/data_stream/issues/elasticsearch/ingest_pipeline/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ processors:
- fingerprint:
fields:
- snyk.issues.id
- snyk.issues.attributes.status
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- snyk.issues.attributes.status
- snyk.issues.attributes.ignored
- snyk.issues.attributes.status

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Copy link
Contributor

@clement-fouque clement-fouque Jul 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment in the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the position is that it may be the case that ignored changes but updated does not? Looking at the API, I don't think that is the case. The reason I included status in the fingerprint is to avoid timestamp collision even though that would be very unlikely. I have added the ignored field though.

- snyk.issues.attributes.updated_at
target_field: _id
ignore_missing: true
- set:
field: vulnerability.scanner.vendor
value: Snyk
Expand Down
2 changes: 1 addition & 1 deletion packages/snyk/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
format_version: "3.0.2"
name: snyk
title: "Snyk"
version: "2.1.0"
version: "2.2.0"
description: Collect logs from Snyk with Elastic Agent.
type: integration
categories:
Expand Down