-
Notifications
You must be signed in to change notification settings - Fork 471
[system] Add support for more event-ids in the security data stream #13828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[system] Add support for more event-ids in the security data stream #13828
Conversation
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
Hi @jamiehynds ,@kcreddy , @efd6, |
LGMT in general, just a couple of things:
|
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
@marc-gr - If you are done with review, can you help me with your approval please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just needs to fix the changelog/manifest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for the linux team... I'm not sure they really have anything to contribute to this PR even though they own a couple of the files.
@marc-gr I have fixed the changelog and manifest. |
@marc-gr @janvi-elastic is this PR ready for merge yet or still waiting on CI to pass? |
@jamiehynds – Everything is done from our side, except for the CI issue, which we aren’t able to fix from our end. @marc-gr Let me know if there’s anything else you’re expecting from us. |
@piyush-elastic, as per the CI error:
You could ignore numeric fields using |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
|
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
Proposed commit message
This PR adds support for more event-ids of
Security Events
tosystem.security
. These events have an event.code as below:System fields are mapped to their corresponding ECS fields where possible. And also added associated dashboards and visualizations.
Test samples were derived from live logs and documentation and subsequently sanitized.
Checklist
How to test this PR locally
Related issues
Screenshot