[Google Threat Intelligence] Add IOC Stream data stream #13449
+26,820
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
dashboard
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
…thub.com/niraj-crest/integrations into ti_google_threat_intelligence_ioc_stream
4 tasks
andrewkroh
added
the
Team:Security-Service Integrations
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
andrewkroh
added
the
Integration:ti_google_threat_intelligence
andrewkroh
added
the
documentation
efd6
reviewed
Jul 6, 2025
| version: '2.3' | ||
| services: | ||
| ti_google_threat_intelligence: | ||
| image: docker.elastic.co/observability/stream:v0.15.0 |
There was a problem hiding this comment.
Suggested change
| image: docker.elastic.co/observability/stream:v0.15.0 | |
| image: docker.elastic.co/observability/stream:v0.18.0 |
| request( | ||
| "GET", | ||
| state.url.trim_right("/") + "/api/v3/ioc_stream?" + { | ||
| "limit": ["40"], |
There was a problem hiding this comment.
Maximum Limit of endpoint,
We kept it hardcoded to reduce network calls.
| "Header": { | ||
| "x-apikey": [state.access_token], | ||
| "x-tool": ["Elastic"], | ||
| "User-Agent": ["v0.1.0"], // Include integration version here; used for identifying and monitoring requests |
There was a problem hiding this comment.
Suggested change
| "User-Agent": ["v0.1.0"], // Include integration version here; used for identifying and monitoring requests | |
| "User-Agent": ["v0.1.0"], // Keep this in sync with 'version' in package level manifest.yml. |
to maintain consistency with other data streams.
| "last_timestamp": has(body.?meta.cursor) ? state.start_time : state.end_time, | ||
| }, | ||
| "want_more": has(body.?meta.cursor), | ||
| "next_page": has(body.?meta.cursor) ? body.meta.cursor : null |
There was a problem hiding this comment.
Suggested change
| "next_page": has(body.?meta.cursor) ? body.meta.cursor : null | |
| "next": { | |
| ?"page": body.?meta.cursor, | |
| "interval": interval, | |
| }, |
Please don't use null to indicate absence.
Comment on lines
+48
to
+53
| "events": ( has(body.data) && size(body.data) > 0 ? | ||
| body.data.map(e, { | ||
| "message": e.encode_json() | ||
| }) | ||
| : | ||
| [{"message": "retry"}] |
There was a problem hiding this comment.
Suggested change
| "events": ( has(body.data) && size(body.data) > 0 ? | |
| body.data.map(e, { | |
| "message": e.encode_json() | |
| }) | |
| : | |
| [{"message": "retry"}] | |
| "events": ( has(body.data) && size(body.data) > 0 ? | |
| body.data.map(e, { | |
| "message": e.encode_json() | |
| }) | |
| : | |
| [{"message": "retry"}] |
Comment on lines
+23
to
+30
| - set: | ||
| field: observer.vendor | ||
| tag: set_observer_vendor | ||
| value: Google | ||
| - set: | ||
| field: observer.product | ||
| tag: set_observer_product | ||
| value: Threat Intelligence |
There was a problem hiding this comment.
Can these be constant_keyword?
Comment on lines
+65
to
+69
| - convert: | ||
| field: json.attributes.asn | ||
| tag: convert_attributes_asn_to_long | ||
| target_field: gti.ioc_stream.attributes.asn | ||
| type: long |
There was a problem hiding this comment.
Is this always safe? (ref) (same below)
Comment on lines
+2458
to
+2463
| if (ctx.threat == null) { | ||
| ctx.threat = new HashMap(); | ||
| } | ||
| if (ctx.threat.indicator == null) { | ||
| ctx.threat.indicator = new HashMap(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (ctx.threat == null) { | |
| ctx.threat = new HashMap(); | |
| } | |
| if (ctx.threat.indicator == null) { | |
| ctx.threat.indicator = new HashMap(); | |
| } | |
| ctx.threat = ctx.thread ?: [:]; | |
| ctx.threat.indicator = ctx.thread.indicator ?: [:]; |
| - append: | ||
| field: tags | ||
| value: preserve_original_event | ||
| allow_duplicates: false |
Comment on lines
+2491
to
+2495
| - set: | ||
| field: event.kind | ||
| tag: set_pipeline_error_into_event_kind | ||
| value: pipeline_error | ||
| if: ctx.error?.message != null |
There was a problem hiding this comment.
Note discussion about this being an array?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist
changelog.ymlfile.How to test this PR locally