Skip to content

[8.19](backport #5156) build(deps): bump github.com/fxamacker/cbor/v2 from 2.8.0 to 2.9.0 #5157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[8.19](backport #5156) build(deps): bump github.com/fxamacker/cbor/v2 from 2.8.0 to 2.9.0 #5157

wants to merge 1 commit into from
+17 −4

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 15, 2025

Bumps github.com/fxamacker/cbor/v2 from 2.8.0 to 2.9.0.

Release notes

Sourced from github.com/fxamacker/cbor/v2's releases.

v2.9.0 adds new features, refactors tests, and improves docs. New features improve interoperability/transcoding between CBOR & JSON.

v2.9.0 passed fuzz tests and is production quality. However, the new TextUnmarshaler feature will continue being fuzz tested a bit longer due to recent changes. The recent changes are limited and don't affect other parts of the codec that passed ~2 billion execs fuzzing.

What's Changed

Docs

CI

Special Thanks

Many thanks to @​benluddy for adding these new features! 🎉

  • Add opt-in support for encoding.TextMarshaler and encoding.TextUnmarshaler to encode and decode from CBOR text string.
  • Add opt-in support for json.Marshaler and json.Unmarshaler via user-provided transcoding function.

New Contributors

Full Changelog: fxamacker/cbor@v2.8.0...v2.9.0

Commits
  • d29ad73 Merge pull request #684 from fxamacker/fxamacker/update-readme-for-v2.9.0
  • 6a631fa Update README for v2.9.0 and add Red Hat as a user
  • 8c8d4c3 Merge pull request #682 from benluddy/textunmarshaler-bytestringtostring
  • 9bdebd2 Use TextUnmarshaler on byte strings with ByteStringToStringAllowed.
  • a89c3ce Merge pull request #680 from fxamacker/dependabot/github_actions/github/codeq...
  • 7ef1742 Bump github/codeql-action from 3.29.0 to 3.29.2
  • 2d79f19 Merge pull request #678 from fxamacker/fxamacker/refactor-tests-and-fix-spell...
  • 0b94ce7 Fix comments to use one "l" in marshal*
  • 508be91 Rename two test funcs that can panic
  • 9251397 Refactor test to use fmt.Appendf
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This is an automatic backport of pull request #5156 done by [Mergify](https://mergify.com).

@dependabot @mergify
build(deps): bump github.com/fxamacker/cbor/v2 from 2.8.0 to 2.9.0 (#…
c848cff 
…5156)

* build(deps): bump github.com/fxamacker/cbor/v2 from 2.8.0 to 2.9.0

Bumps [github.com/fxamacker/cbor/v2](https://github.com/fxamacker/cbor) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/fxamacker/cbor/releases)
- [Commits](fxamacker/cbor@v2.8.0...v2.9.0)

---
updated-dependencies:
- dependency-name: github.com/fxamacker/cbor/v2
  dependency-version: 2.9.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Post dependabot file modifications

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 9ac161c)

# Conflicts:
#	go.mod
#	go.sum
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jul 15, 2025
@mergify mergify bot requested a review from a team as a code owner July 15, 2025 11:40
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Jul 15, 2025

Cherry-pick of 9ac161c has failed:

On branch mergify/bp/8.19/pr-5156
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 9ac161c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   NOTICE-fips.txt
	modified:   NOTICE.txt

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   go.mod
	both modified:   go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from rubenruizdegauna July 15, 2025 11:40
@mergify mergify bot added the backport label Jul 15, 2025
@mergify mergify bot requested a review from pchila July 15, 2025 11:40
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Jul 15, 2025
@github-actions github-actions bot added automation dependency Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Jul 15, 2025
@prodsecmachine
Copy link

prodsecmachine commented Jul 15, 2025 •
edited
Loading

⚠️ Snyk checks are incomplete.

⚠️ security/snyk check encountered an error. (View Details)

⚠️ license/snyk check encountered an error. (View Details)

@pchila
Copy link
Member

pchila commented Jul 15, 2025

@swiatekm why is this minor version bump being backported to a release branch ?
I thought we agreed that release branches would only get patch version bumps.

/cc @ebeahan

@swiatekm
Copy link
Contributor

@swiatekm why is this minor version bump being backported to a release branch ? I thought we agreed that release branches would only get patch version bumps.

/cc @ebeahan

8.19 is the last branch in the 8.x series, so we'll be supporting it longer. It's also getting one more build candidate before release on the 29th. I think we should get as many safe dependency updates in there as possible.

@pchila
Copy link
Member

pchila commented Jul 16, 2025

@swiatekm why is this minor version bump being backported to a release branch ? I thought we agreed that release branches would only get patch version bumps.
/cc @ebeahan

8.19 is the last branch in the 8.x series, so we'll be supporting it longer. It's also getting one more build candidate before release on the 29th. I think we should get as many safe dependency updates in there as possible.

For the same reasons it's important to keep it stable. If we are forced to bump dependencies beyond patch versions increments we can always do it when there's actually a need.

@swiatekm
Copy link
Contributor

@swiatekm why is this minor version bump being backported to a release branch ? I thought we agreed that release branches would only get patch version bumps.
/cc @ebeahan

8.19 is the last branch in the 8.x series, so we'll be supporting it longer. It's also getting one more build candidate before release on the 29th. I think we should get as many safe dependency updates in there as possible.

For the same reasons it's important to keep it stable. If we are forced to bump dependencies beyond patch versions increments we can always do it when there's actually a need.

Allright, I'm going to close this PR then. We can continue this discussion in a more appropriate setting. If nothing else, we should have a policy explicitly written down to reference in these kinds of situations.

@swiatekm swiatekm closed this Jul 16, 2025
@swiatekm swiatekm deleted the mergify/bp/8.19/pr-5156 branch July 16, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenruizdegauna rubenruizdegauna Awaiting requested review from rubenruizdegauna rubenruizdegauna is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees
No one assigned
Labels
automation backport conflicts There is a conflict in the backported pull request dependency Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prodsecmachine @pchila @swiatekm