build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.11.16 to 0.11.18 #5089
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/elastic/elastic-agent-system-metrics](https://github.com/elastic/elastic-agent-system-metrics) from 0.11.16 to 0.11.18. - [Release notes](https://github.com/elastic/elastic-agent-system-metrics/releases) - [Commits](elastic/elastic-agent-system-metrics@v0.11.16...v0.11.18) --- updated-dependencies: - dependency-name: github.com/elastic/elastic-agent-system-metrics dependency-version: 0.11.18 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
automation
dependency
Team:Elastic-Agent-Control-Plane
dependabot
bot
added
dependency
Team:Elastic-Agent-Control-Plane
|
This pull request does not have a backport label. Could you fix it @dependabot[bot]? 🙏
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
internal/pkg/api/metrics.go
Outdated
| @@ -78,6 +73,11 @@ func init() { | |||
| cntFileDeliv.Register(routesRegistry.newRegistry("deliverFile")) | |||
| cntGetPGP.Register(routesRegistry.newRegistry("getPGPKey")) | |||
| cntAuditUnenroll.Register(routesRegistry.newRegistry("auditUnenroll")) | |||
|
|
|||
| err := report.SetupMetrics(logger.NewZapStub("instance-metrics"), build.ServiceName, version.DefaultVersion, registry.registry, registry.registry) | |||
There was a problem hiding this comment.
@kruskall, you introduced the new signature here, can we use the same registry for both args here?
There was a problem hiding this comment.
mmh, the previous behaviour was to use separate registries.
The idea is that now you have to pass them explicitly instead of relying on the global one
There was a problem hiding this comment.
for reference this is what we do in apm-server: https://github.com/elastic/apm-server/blob/5c0b8e70748dc693a9ef89de5e454d50592889ce/internal/beatcmd/beat.go#L398
|
|
This pull request is now in conflicts. Could you fix it @dependabot[bot]? 🙏 |
Bumps github.com/elastic/elastic-agent-system-metrics from 0.11.16 to 0.11.18.
Release notes
Sourced from github.com/elastic/elastic-agent-system-metrics's releases.
Commits
d6cb3a9lint: remove unused import (#250)69e11a2feat: require passing registries for metrics setup (#247)970079bfix: solaris build support (#248)6f4567bfeat: remove unused SetupInfoUserMetrics (#246)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)