[DiskBBQ] Change IOContext.DEFAULT.withReadAdvice(ReadAdvice.SEQUENTIAL) with IOContext.READONCE #133666
+2
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AL) with IOContext.READONCE
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
benwtrent
reviewed
Aug 27, 2025
Comment on lines
+302
to
+303
| IndexInput vectors = mergeState.segmentInfo.dir.openInput(tempRawVectorsFileName, IOContext.READONCE); | ||
| IndexInput docs = docsFileName == null ? null : mergeState.segmentInfo.dir.openInput(docsFileName, IOContext.READONCE) |
There was a problem hiding this comment.
I think this is OK. None of the inputs are accessed from a different thread other than this one.
There was a problem hiding this comment.
yes, and this is changing very soon with the new API.
benwtrent
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOContext.DEFAULT.withReadAdvice(ReadAdvice.SEQUENTIAL) has currently a very specific meaning in the hybrid directory and it prevents files to be mmapped. Thid behavior is not desrired so lets change it with IOContext.READONCE. Note that this will change in the next release of lucene and we will have the right API to define it.