-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Update FIRST
and LAST
to accept keyword and text
#133642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
romulets
wants to merge
15
commits into
elastic:main
Choose a base branch
from
romulets:first-last-keyword
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,399
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-analytical-engine (Team:Analytics) |
FIRST
and LAST
to accept keyword
b3621e8
to
4e61eab
Compare
romulets
commented
Aug 27, 2025
.../generated-src/org/elasticsearch/compute/aggregation/FirstBytesRefByTimestampAggregator.java
Outdated
Show resolved
Hide resolved
romulets
commented
Aug 27, 2025
.../generated-src/org/elasticsearch/compute/aggregation/FirstBytesRefByTimestampAggregator.java
Show resolved
Hide resolved
nik9000
reviewed
Aug 27, 2025
x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/X-2State.java.st
Outdated
Show resolved
Hide resolved
...ute/src/main/java/org/elasticsearch/compute/aggregation/X-ValueByTimestampAggregator.java.st
Outdated
Show resolved
Hide resolved
...ute/src/main/java/org/elasticsearch/compute/aggregation/X-ValueByTimestampAggregator.java.st
Outdated
Show resolved
Hide resolved
...ute/src/main/java/org/elasticsearch/compute/aggregation/X-ValueByTimestampAggregator.java.st
Outdated
Show resolved
Hide resolved
a96304c
to
84ee794
Compare
nik9000
reviewed
Aug 28, 2025
x-pack/plugin/esql/qa/testFixtures/src/main/resources/stats_last.csv-spec
Show resolved
Hide resolved
FIRST
and LAST
to accept keywordFIRST
and LAST
to accept keyword and text
7404778
to
a4e9fcb
Compare
nik9000
approved these changes
Aug 28, 2025
x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/X-2State.java.st
Outdated
Show resolved
Hide resolved
81b4017
to
2aac264
Compare
f9960f2
to
5ff4fe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
external-contributor
Pull request authored by a developer outside the Elasticsearch team
>feature
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #132603 enable keyword and text to be used in
FIRST
andLAST
.Relates to