Extend HTTP timeout in repo analysis tests #131744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We set a 120s timeout on the repo analysis that runs in these tests, but the REST client in use has a read timeout of 60s so any analysis that lasts longer than that will yield an HTTP timeout that contains very limited information to help further investigation. With this commit we extend the HTTP timeout to be a few seconds longer than the analysis timeout so we should get a proper response in these cases.
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DiannaHohensee
approved these changes
Jul 23, 2025
| request.addParameter("seed", Long.toString(randomLong())); | ||
| request.setOptions( | ||
| RequestOptions.DEFAULT.toBuilder() | ||
| .setRequestConfig(RequestConfig.custom().setSocketTimeout(Math.toIntExact(timeout.millis() + 10_000)).build()) |
There was a problem hiding this comment.
Suggested change
| .setRequestConfig(RequestConfig.custom().setSocketTimeout(Math.toIntExact(timeout.millis() + 10_000)).build()) | |
| .setRequestConfig(RequestConfig.custom().setSocketTimeout(Math.toIntExact(timeout.seconds() + 10)).build()) |
You have seconds above and milliseconds here. We're probably more accustomed to thinking in milliseconds, so leaving it as-is is fine with me, too 🤷♀️
There was a problem hiding this comment.
the parameter to setSocketTimeout is a raw integer representing the timeout in milliseconds - we could add ten seconds like this but then we'd have to convert it to millis either by multiplying by another magic number or else converting it back to a TimeValue and back again
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jul 30, 2025
We set a 120s timeout on the repo analysis that runs in these tests, but the REST client in use has a read timeout of 60s so any analysis that lasts longer than that will yield an HTTP timeout that contains very limited information to help further investigation. With this commit we extend the HTTP timeout to be a few seconds longer than the analysis timeout so we should get a proper response in these cases.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jul 30, 2025
We set a 120s timeout on the repo analysis that runs in these tests, but the REST client in use has a read timeout of 60s so any analysis that lasts longer than that will yield an HTTP timeout that contains very limited information to help further investigation. With this commit we extend the HTTP timeout to be a few seconds longer than the analysis timeout so we should get a proper response in these cases.
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jul 30, 2025
We set a 120s timeout on the repo analysis that runs in these tests, but the REST client in use has a read timeout of 60s so any analysis that lasts longer than that will yield an HTTP timeout that contains very limited information to help further investigation. With this commit we extend the HTTP timeout to be a few seconds longer than the analysis timeout so we should get a proper response in these cases. Backport of elastic#131744 to 9.0
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jul 30, 2025
We set a 120s timeout on the repo analysis that runs in these tests, but the REST client in use has a read timeout of 60s so any analysis that lasts longer than that will yield an HTTP timeout that contains very limited information to help further investigation. With this commit we extend the HTTP timeout to be a few seconds longer than the analysis timeout so we should get a proper response in these cases. Backport of elastic#131744 to 8.18
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 30, 2025
We set a 120s timeout on the repo analysis that runs in these tests, but the REST client in use has a read timeout of 60s so any analysis that lasts longer than that will yield an HTTP timeout that contains very limited information to help further investigation. With this commit we extend the HTTP timeout to be a few seconds longer than the analysis timeout so we should get a proper response in these cases. Backport of #131744 to 8.18
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 30, 2025
We set a 120s timeout on the repo analysis that runs in these tests, but the REST client in use has a read timeout of 60s so any analysis that lasts longer than that will yield an HTTP timeout that contains very limited information to help further investigation. With this commit we extend the HTTP timeout to be a few seconds longer than the analysis timeout so we should get a proper response in these cases. Backport of #131744 to 9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set a 120s timeout on the repo analysis that runs in these tests, but
the REST client in use has a read timeout of 60s so any analysis that
lasts longer than that will yield an HTTP timeout that contains very
limited information to help further investigation. With this commit we
extend the HTTP timeout to be a few seconds longer than the analysis
timeout so we should get a proper response in these cases.