Remove ordinal grouping path in aggregations #131307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
remove-ordinal-grouping
branch
from
76b06b8 to
45e2587
Compare
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
ivancea
approved these changes
Jul 16, 2025
| @@ -121,7 +121,7 @@ | |||
| * It is also possible to declare any number of arbitrary arguments that must be provided via generated Supplier. | |||
| * </li> | |||
| * <li> | |||
| * {@code combine, combineStates, combineIntermediate, evaluateFinal} methods (see below) could be generated automatically | |||
There was a problem hiding this comment.
I wonder if it would be worth it keeping the combineStates(), in case we want to reuse it later. For some node-level initial agg reduction. I think we talked about it at some point.
Not sure if it's really worth it. Commenting mostly because we're throwing quite some code.
However, I see there are no tests being removed though, so I suppose this wasn't tested either
There was a problem hiding this comment.
I thought about this as well :), but I think it's better to remove this path because it would add more work when implementing new aggregation functions and make changes to the current aggregation functions more difficult.
|
Thanks Ivan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the ordinal grouping operator removed in #131133, this PR removes the corresponding code path in the grouping aggregator function, as it is no longer needed.
Relates #131133