Correctly handling download_database_on_pipeline_creation within a pipeline processor within a default or final pipeline #131236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peline processor within a default or final pipeline
masseyke
added
>bug
:Data Management/Ingest Node
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @masseyke, I've created a changelog YAML for you. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…thub.com:masseyke/elasticsearch into fix/geoip-download_database_on_pipeline_creation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where GeoIP databases were not being downloaded when download_database_on_pipeline_creation is set to false but the GeoIP processor is referenced through nested pipeline processors within default or final pipelines. The fix ensures proper recursive traversal of pipeline processors to detect GeoIP processors at any nesting level.
Key changes:
- Enhanced GeoIP processor detection to recursively traverse pipeline processors
- Added cycle detection to prevent stack overflow in pipelines with circular references
- Comprehensive test coverage for nested pipeline scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| GeoIpDownloaderTaskExecutor.java | Core logic enhancement to recursively detect GeoIP processors in nested pipeline processors with cycle detection |
| GeoIpDownloaderTaskExecutorTests.java | New test cases covering nested pipeline scenarios and recursive pipeline detection |
| docs/changelog/131236.yaml | Changelog entry documenting the bug fix |
...s/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloaderTaskExecutor.java
Outdated
Show resolved
Hide resolved
...s/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloaderTaskExecutor.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are supposed to load a geoip database even if
download_database_on_pipeline_creationis set to false, if it is referenced from a default or final processor. However, if the geoip processor is referenced from a pipeline that is referenced as a pipeline processor from the default or final pipeline, we do not correctly do this. The result is that the database is not downloaded, and all data is tagged with something like_geoip_database_unavailable_GeoLite2-City.mmdbrather than having geo data added to it.Related: #96624