Skip to content

Add track_total_hits to search_mvt #4850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025
Merged

Add track_total_hits to search_mvt #4850

merged 2 commits into from
Jul 11, 2025

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jul 9, 2025

I did check that is accepted.

Copy link
Contributor

github-actions bot commented Jul 9, 2025

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin mentioned this pull request Jul 9, 2025
25 tasks
@pquentin pquentin requested a review from Anaethelion July 11, 2025 06:34
@pquentin pquentin merged commit 069159f into main Jul 11, 2025
8 checks passed
@pquentin pquentin deleted the rest-api-spec-search-mvt branch July 11, 2025 08:33
Copy link
Contributor

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-4850-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 069159ff8c726f9131ffefafd702c09285065623
# Push it to GitHub
git push --set-upstream origin backport-4850-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-4850-to-8.19.

Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-4850-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 069159ff8c726f9131ffefafd702c09285065623
# Push it to GitHub
git push --set-upstream origin backport-4850-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-4850-to-8.18.

github-actions bot pushed a commit that referenced this pull request Jul 11, 2025
github-actions bot pushed a commit that referenced this pull request Jul 11, 2025
pquentin added a commit that referenced this pull request Jul 11, 2025
(cherry picked from commit 069159f)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Jul 11, 2025
(cherry picked from commit 069159f)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin pushed a commit that referenced this pull request Jul 11, 2025
(cherry picked from commit 069159f)

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 5c415de)

# Conflicts:
#	output/schema/schema.json
pquentin pushed a commit that referenced this pull request Jul 11, 2025
(cherry picked from commit 069159f)

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 5c415de)

# Conflicts:
#	output/schema/schema.json
pquentin added a commit that referenced this pull request Jul 11, 2025
(cherry picked from commit 069159f)

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 5c415de)

# Conflicts:
#	output/schema/schema.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pquentin added a commit that referenced this pull request Jul 11, 2025
(cherry picked from commit 069159f)

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 5c415de)

# Conflicts:
#	output/schema/schema.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants