-
Notifications
You must be signed in to change notification settings - Fork 234
Unifying Elastic vector database and LLM functions for intelligent query Part 2 #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/453 |
"from IPython.display import Markdown, display\n", | ||
"import requests, json\n", | ||
"from getpass import getpass\n", | ||
"from google.colab import userdata\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you mention at the top of the document that this notebook must run in a Google Colab environment?
@sunilemanjee I've spotted a couple of things:
|
@carlyrichmond i'm slightly confused. There is no notebook in this demo or article Can you change the example to use endpoint instead of Cloud ID? That has been the standard for a while.
Can you also list the prerequisites need at the top of the notebook as well. It needs several different endpoints and keys, so having it all at the start with any useful setup guides (in addition to what you have in the accompanying blog) would be useful.
Any change you can update the piece to at least 8.18? I get that 8.17 was the latest at the time of writing.
|
@sunilemanjee I see in the commit history that this PR is picking up commits on the following notebook: supporting-blog-content/unifying-elastic-vector-database-and-llms-for-intelligent-query/Unifying_Elastic_Vector_Database_and_LLMs_for_Intelligent_Query_Part_2.ipynb Is that not correct? |
@carlyrichmond this article does not have a notebook. all the code is referenced within the code repo @justincastilla has been reviewing. |
@sunilemanjee that may be the case, but this PR that I am commenting on here has changes to a notebook showing in the commit history: ![]() Perhaps something is linked incorrectly, or small changes have been made to a notebook for a different article? @justincastilla can you sync with @sunilemanjee and get this closed out please? It's been sitting quite a while and we need to try and close it out. |
Related to topic: https://github.com/orgs/elastic/projects/1446/views/1?filterQuery=llm+function&pane=issue&itemId=107821356&issue=elastic%7Csearch-labs-elastic-co%7C1535
I wrote part one here: https://www.elastic.co/search-labs/blog/llm-functions-elasticsearch-intelligent-query
This is part 2. Uses a different dataset (homes/properties instead of hotels) with the same intelligent query pattern identified in part 1. Additional part two leverages serverless and ships with a UI for search.