codegen 8.19 fix scripts #2997
Closed
codegen 8.19 fix scripts #2997
+51,049
−31,696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
margaretjgu
commented
Aug 26, 2025
.github/make.sh
Outdated
| @@ -22,7 +22,7 @@ | |||
| # ------------------------------------------------------- # | |||
| # Bootstrap | |||
| # ------------------------------------------------------- # | |||
| script_path=$(dirname "$(realpath -s "$0")") | |||
| script_path=$(dirname "$(realpath "$0")") | |||
There was a problem hiding this comment.
realpath: illegal option -- s
usage: realpath [-q] [path ...]
unfortunately realpath -s doesnt not exist for mac but does for linux
margaretjgu
commented
Aug 26, 2025
| RUN (id -g ${BUILDER_GID} || groupadd --system -g ${BUILDER_GID} ${BUILDER_GROUP}) \ | ||
| && (id -u ${BUILDER_UID} || useradd --system --shell /bin/bash -u ${BUILDER_UID} -g ${BUILDER_GID} -m elastic) \ | ||
| RUN (getent group ${BUILDER_GID} || groupadd --system -g ${BUILDER_GID} ${BUILDER_GROUP}) \ | ||
| && (getent passwd ${BUILDER_UID} || useradd --system --shell /bin/bash -u ${BUILDER_UID} -g ${BUILDER_GID} -m elastic) \ |
There was a problem hiding this comment.
ERROR: failed to solve: process "/bin/sh -c (id -g ${BUILDER_GID} || groupadd --system -g ${BUILDER_GID} ${BUILDER_GROUP})"
------
> [3/7] RUN (id -g 20 || groupadd --system -g 20 elastic) && (id -u 501 || useradd --system --shell /bin/bash -u 501 -g 20 -m elastic) && mkdir -p /usr/src/elasticsearch-js && chown -R 501:20 /usr/src/:
0.115 id: '20': no such user
0.116 groupadd: GID '20' already exists
use getent to check if group and user id exists, if not then it creates. if exists, then skip creating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.