-
Notifications
You must be signed in to change notification settings - Fork 176
Associate ESS metadata with job ids #9056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
I think the attempt in the earlier commit and into the same issue; i've added some echo statements so we can be sure what we're referencing. i'll run the tests a few times to see if it re-occurs |
buildkite test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, this is related to the step at
elastic-agent/.buildkite/bk.integration-fips.pipeline.yml
Lines 21 to 35 in 5ce4871
- label: Start ESS stack for FIPS integration tests | |
key: integration-fips-ess | |
env: | |
ASDF_TERRAFORM_VERSION: 1.9.2 | |
TF_VAR_integration_server_docker_image: "docker.elastic.co/beats-ci/elastic-agent-cloud-fips:git-${BUILDKITE_COMMIT:0:12}" | |
command: | | |
source .buildkite/scripts/steps/ess_start.sh | |
artifact_paths: | |
- test_infra/ess/*.tfstate | |
- test_infra/ess/*.lock.hcl | |
agents: | |
image: "docker.elastic.co/ci-agent-images/platform-ingest/buildkite-agent-beats-ci-with-hooks:0.5" | |
useCustomGlobalHooks: true | |
plugins: | |
- *vault_ec_key_prod |
@v1v the deployment used by FIPS testing is different from the deployments used by normal integration tests, and custom ECH test. The difference is as follows:
We needed to separate FIPS from non-FIPS as the binary differs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however I'll wait for a second review to play safe.
I can see builds are running those new steps:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michel-laterman still the fips builds are not using the fips ESS stack
- fips integration testing step https://buildkite.com/elastic/elastic-agent/builds/24300#01982dfc-5b6c-4aed-bbac-204f1ae6fa95/805-807
- fips ESS provision step https://buildkite.com/elastic/elastic-agent/builds/24300#01982dfc-5b6a-439d-9308-3993dca6eae0/143-347
- non fips ESS provision step https://buildkite.com/elastic/elastic-agent/builds/24300#01982dfc-41f8-4475-8693-1a7c03753809/142-359
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michel-laterman I still see mixed up non-FIPS integration test steps with FIPS stack:
- non-FIPS integration test here, and here
- non-FIPS ESS Stack provisioning here
- FIPS ESS Stack provisioning here
PS: please also print the Elasticsearch Host for tests that run on Windows
Looks like we still have some (fips) pipeline issues:
Looks like a test runs before the FIPS provisioning is complete |
💛 Build succeeded, but was flaky
Failed CI Steps
History
|
|
What does this PR do?
Assoicate ESS metadata with Job IDS
Why is it important?
There are timing issues inbetween FIPS and non-FIPS ESS testing where FIPS tests can retrieve data for non-FIPS deployments.
Related issues