Skip to content

Update Pull Request Template #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

Update Pull Request Template #2498

merged 2 commits into from
Jul 14, 2025

Conversation

mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Jul 4, 2025

1. What does this PR do?

Update the new pull request template to the template used for this PR.

2. Which ECS fields are affected/introduced?

None

3. Why is this change necessary?

This will help ECS contributors be able to make better contributions by explaining what's needed for PRs to be accepted. It helps them know how to prepare a PR, by linking to more documentation and explain how to build and test ECS from within the template.

4. Have you added/updated documentation?

N/A - This only changes the PR template

5. Have you built ECS and committed any newly generated files?

NO

6. Have you run the ECS validation tests locally?

NO

7. Anything else for the reviewers?


Commit Message

Update the PR template to list all steps required to create an
acceptable PR, link to more documentation on contributing to ECS, and
add guidance on how to build and test ECS within the template.

Update the PR template to list all steps required to create an
acceptable PR, link to more documentation on contributing to ECS, and
add guidance on how to build and test ECS within the template.
@mjwolf mjwolf requested a review from a team as a code owner July 4, 2025 21:20
Copy link

github-actions bot commented Jul 4, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjwolf mjwolf merged commit 9b0461a into elastic:main Jul 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants