-
Notifications
You must be signed in to change notification settings - Fork 446
Clarify url.query usage to specify full query string format #2488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This update removes ambiguity around the url.query field by explicitly stating that it should contain the full query string, including compound parameters. An example with multiple query parameters is added to reinforce this guidance. This helps prevent misinterpretation—such as splitting the query into an array of keywords—and promotes consistent, ECS-compliant implementations across ingestion pipelines and tools.
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 CLA has been signed |
4d5c51e
to
d76d6d8
Compare
run docs-build |
we could also add a link to definition as we do in semantic conventions https://opentelemetry.io/docs/specs/semconv/registry/attributes/url/ |
Hi! We just realized that we haven't looked into this PR in a while. We're We're labeling this PR as Thank you for your contribution! |
This update removes ambiguity around the url.query field by explicitly stating that it should contain the full query string, including compound parameters.
An example with multiple query parameters is added to reinforce this guidance. This helps prevent misinterpretation—such as splitting the query into an array of keywords—and promotes consistent, ECS-compliant implementations across ingestion pipelines and tools.
make test
?make
and committed those changes?