Skip to content

Update running-on-kubernetes-managed-by-fleet.md deploy command #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2025

Conversation

eedugon
Copy link
Contributor

@eedugon eedugon commented Aug 4, 2025

This PR fixes an incorrect URL and adds an example using the latest version (using {{version.stack}}), so it can be easily used with copying and pasting.

Add curl example for latest version using substitution
@eedugon eedugon requested a review from a team as a code owner August 4, 2025 15:55
Copy link

github-actions bot commented Aug 4, 2025

🔍 Preview links for changed docs

@eedugon
Copy link
Contributor Author

eedugon commented Aug 4, 2025

@alexandra5000 : on this commit you changed the URL for a URL that does not provide a raw YAML, but a HTLM page. That cannot be used in the procedure.

@ebeahan : would you please share some insights with us? I think you requested this change on #1481, and I don't know if we have done something wrong or if there's a misunderstanding, but a link to https://github.com/elastic/elastic-agent/blob/v9.1.0/deploy/kubernetes/elastic-agent-managed-kubernetes.yaml is not valid to download the YAML file.

It has to be something like the old links:
https://raw.githubusercontent.com/elastic/elastic-agent/9.1/deploy/kubernetes/elastic-agent-managed-kubernetes.yaml

If you agree I can fix that in this PR, and If there is another way to grab the file including major.minor.patch instead of just major.minor I'd be happy to use it. But we cannot use a URL that returns a HTML page, as kubectl will not work with that.

@vishaangelova
Copy link
Contributor

vishaangelova commented Aug 4, 2025

@eedugon how about this raw content file from the release tag (it has the patch version, too): https://raw.githubusercontent.com/elastic/elastic-agent/refs/tags/v9.1.0/deploy/kubernetes/elastic-agent-managed-kubernetes.yaml

Would that work?

So we could use it in the example like this:

curl -L -O https://raw.githubusercontent.com/elastic/elastic-agent/refs/tags/v{{version.stack}}/deploy/kubernetes/elastic-agent-managed-kubernetes.yaml

@ebeahan
Copy link
Member

ebeahan commented Aug 4, 2025

@eedugon Yes, update the URL as necessary to pull the actual YAML file. As @vishaangelova suggested, we want to use a release tag and avoid users pulling anything pre-release from main.

@eedugon
Copy link
Contributor Author

eedugon commented Aug 5, 2025

thanks @vishaangelova and @ebeahan !

@eedugon eedugon merged commit 69b258f into main Aug 5, 2025
7 checks passed
@eedugon eedugon deleted the eedugon-patch-1 branch August 5, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants