Skip to content

Cloud Asset Discovery integration #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Aug 8, 2025
Merged

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Aug 1, 2025

Fixes #2078

Creates documentation for the new Cloud Asset Discovery integration. There's a main landing page, plus three platform-specific guides for GCP, Azure, and AWS. Refer to this comment for docs previews. (Note, the updates to the CSPM setup guides are very minor.)

Also improves formatting throughout the cloud security section (code annotations, paragraphs -> lists), reduces directional language per our accessibility guidelines (thanks Florent!), and removes references to specific subscription levels per our legal guidelines (thanks Brandon!).

Thanks in advance for your input!

@benironside benironside self-assigned this Aug 1, 2025
@benironside benironside requested a review from caitlinbetz August 1, 2025 22:39
@benironside benironside marked this pull request as ready for review August 1, 2025 23:05
@benironside benironside requested review from a team as code owners August 1, 2025 23:05
@caitlinbetz caitlinbetz requested a review from romulets August 4, 2025 11:19
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this need applies_to tags? (is it new for 9.1, or became GA in 9.1?)

Edit: I missed some files, will review again

@florent-leborgne florent-leborgne self-requested a review August 5, 2025 09:42
@florent-leborgne florent-leborgne dismissed their stale review August 5, 2025 12:49

Missed some files

Copy link
Member

@romulets romulets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. In the meantime, I believe we should make time and test all the methods here describe to make sure they are accurate

Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. I left mostly some formatting/accessibility comments on certain items, but that also apply to other parts of these changes. Feel free to apply them here, or to create a follow-up issue to tackle those things in a different PR

@benironside
Copy link
Contributor Author

LGTM overall. I left mostly some formatting/accessibility comments on certain items, but that also apply to other parts of these changes. Feel free to apply them here, or to create a follow-up issue to tackle those things in a different PR

Thanks for the great suggestions @florent-leborgne! Will track these enhancements in 2467

Copy link

@uri-weisman uri-weisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A few comments.

@benironside benironside enabled auto-merge (squash) August 8, 2025 17:11
@bmorelli25
Copy link
Member

bmorelli25 commented Aug 8, 2025

Thanks for the great suggestions @florent-leborgne! Will track these enhancements in #2467

With #2440 now merged, you should consider closing #2467 and addressing @florent-leborgne's comments in this PR

@benironside benironside disabled auto-merge August 8, 2025 19:47
@benironside benironside merged commit 33ca2ef into main Aug 8, 2025
6 of 7 checks passed
@benironside benironside deleted the 2078-asset-discovery-integration branch August 8, 2025 20:25
Comment on lines +1 to +6
---
applies_to:
stack: all
serverless:
security: all
---
Copy link
Member

@bmorelli25 bmorelli25 Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This excludes any mention of technical preview and reads as if this feature is GA in 9.0.

benironside added a commit that referenced this pull request Aug 8, 2025
Follow up PR to #2381, fixes
the applies to labels for the Cloud Asset Discovery integration docs.

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Internal]: Cloud Asset Discovery Integration docs.
6 participants