-
Notifications
You must be signed in to change notification settings - Fork 127
Cloud Asset Discovery integration #2381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…/elastic/docs-content into 2078-asset-discovery-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Does this need applies_to tags? (is it new for 9.1, or became GA in 9.1?)
Edit: I missed some files, will review again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. In the meantime, I believe we should make time and test all the methods here describe to make sure they are accurate
…/elastic/docs-content into 2078-asset-discovery-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. I left mostly some formatting/accessibility comments on certain items, but that also apply to other parts of these changes. Feel free to apply them here, or to create a follow-up issue to tackle those things in a different PR
Thanks for the great suggestions @florent-leborgne! Will track these enhancements in 2467 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. A few comments.
With #2440 now merged, you should consider closing #2467 and addressing @florent-leborgne's comments in this PR |
…/elastic/docs-content into 2078-asset-discovery-integration
--- | ||
applies_to: | ||
stack: all | ||
serverless: | ||
security: all | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This excludes any mention of technical preview and reads as if this feature is GA in 9.0.
Follow up PR to #2381, fixes the applies to labels for the Cloud Asset Discovery integration docs. Thanks!
Fixes #2078
Creates documentation for the new Cloud Asset Discovery integration. There's a main landing page, plus three platform-specific guides for GCP, Azure, and AWS. Refer to this comment for docs previews. (Note, the updates to the CSPM setup guides are very minor.)
Also improves formatting throughout the cloud security section (code annotations, paragraphs -> lists), reduces directional language per our accessibility guidelines (thanks Florent!), and removes references to specific subscription levels per our legal guidelines (thanks Brandon!).
Thanks in advance for your input!