-
Notifications
You must be signed in to change notification settings - Fork 121
Fix up the 'Templates' section #2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I've added some suggestions for the explanations and descriptions around component templates and index templates.
btw, I've also found this insteresting blog that I'm not sure if it could make sense to link also: https://www.elastic.co/search-labs/blog/index-composable-templates
In this doc we also mention legacy templates
but we don't give any context or link..... so I don't know how best to address this. I don't even know if we have the old legacy templates behavior documented (this is an old doc about legacy templates).
manage-data/data-store/templates.md
Outdated
* Composable templates take precedence over legacy templates. If no composable template matches a given index, a legacy template may still match and be applied. | ||
The following conditions apply to using templates: | ||
|
||
* Composable index templates take precedence over legacy templates. If no composable template matches a given index, a legacy template may still match and be applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a link in legacy templates
? The concept of legacy templates doesn't appear in the doc, and might be difficult for a reader to understand what's about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing that link. In commit 24fb6bf I changed this line to:
Composable index templates take precedence over any legacy templates, which were deprecated in {{es}} 7.8.
Co-authored-by: Edu González de la Herrán <[email protected]>
Co-authored-by: Edu González de la Herrán <[email protected]>
Co-authored-by: Edu González de la Herrán <[email protected]>
Co-authored-by: Edu González de la Herrán <[email protected]>
Co-authored-by: Edu González de la Herrán <[email protected]>
Thanks a lot for the feedback @eedugon!
Definitely. I added a tip at the bottom of the intro section:
Thanks for the link to that page. I added the link and mentioned that legacy templates are deprecated. Let me know if you think those changes are okay. :-) |
This attempts to improve the Templates docs by:
Please see preview page: Templates
@eedugon This was prompted by your suggestions here so I hope you don't mind my adding you as a reviewer. 🙏
Closes: #2056