fix(ebounty.lic): v1.9.4 and optimize location_list#2237
Merged
Conversation
Updated version to 1.9.4 and optimized location_list logic.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to c1e7577 in 25 seconds. Click for details.
- Reviewed
46lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_ijtMH4DdyMG05UJv
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Refactor forage_find method to improve readability and efficiency by using case expressions and filtering location lists more effectively.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to a077748 in 21 seconds. Click for details.
- Reviewed
125lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_6HKtmKgbGzKTbo1h
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Removed unused variable 'current_room_id' from distance calculation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated version to 1.9.4 and optimized location_list logic.
Important
Update
ebounty.licto version 1.9.4 and optimizeforage_findfunction for better performance in location filtering.1.9.4inebounty.lic.location_listlogic inforage_findfunction to improve performance by usingselectandmapfor filtering and mapping room IDs.forage_find: Refactor to useselectfor filtering rooms with matching herb tags andmapto extract room IDs.forage_find: Addselect!to filter rooms by herb pattern and location pattern if location is not "nearest".forage_find: Sort and limitlocation_listto 10 nearest rooms if location is "nearest".This description was created by
for a077748. You can customize this summary. It will automatically update as commits are pushed.