Skip to content

fix(ebounty.lic): v1.9.4 and optimize location_list#2237

Merged
mrhoribu merged 3 commits intomasterfrom
fix/ebounty-v1.9.4
Feb 5, 2026
Merged

fix(ebounty.lic): v1.9.4 and optimize location_list#2237
mrhoribu merged 3 commits intomasterfrom
fix/ebounty-v1.9.4

Conversation

@mrhoribu
Copy link
Contributor

@mrhoribu mrhoribu commented Feb 5, 2026

Updated version to 1.9.4 and optimized location_list logic.


Important

Update ebounty.lic to version 1.9.4 and optimize forage_find function for better performance in location filtering.

  • Behavior:
    • Update version to 1.9.4 in ebounty.lic.
    • Optimize location_list logic in forage_find function to improve performance by using select and map for filtering and mapping room IDs.
  • Functions:
    • forage_find: Refactor to use select for filtering rooms with matching herb tags and map to extract room IDs.
    • forage_find: Add select! to filter rooms by herb pattern and location pattern if location is not "nearest".
    • forage_find: Sort and limit location_list to 10 nearest rooms if location is "nearest".

This description was created by Ellipsis for a077748. You can customize this summary. It will automatically update as commits are pushed.

Updated version to 1.9.4 and optimized location_list logic.
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to c1e7577 in 25 seconds. Click for details.
  • Reviewed 46 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_ijtMH4DdyMG05UJv

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Refactor forage_find method to improve readability and efficiency by using case expressions and filtering location lists more effectively.
@mrhoribu mrhoribu marked this pull request as draft February 5, 2026 01:15
@mrhoribu mrhoribu marked this pull request as ready for review February 5, 2026 01:15
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to a077748 in 21 seconds. Click for details.
  • Reviewed 125 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_6HKtmKgbGzKTbo1h

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Removed unused variable 'current_room_id' from distance calculation.
@mrhoribu mrhoribu merged commit 696abde into master Feb 5, 2026
3 checks passed
@mrhoribu mrhoribu deleted the fix/ebounty-v1.9.4 branch February 5, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant