Skip to content

feat(map.lic): v2.0.0 refactor#2207

Open
mrhoribu wants to merge 10 commits intomasterfrom
feat/map-v2.0.0
Open

feat(map.lic): v2.0.0 refactor#2207
mrhoribu wants to merge 10 commits intomasterfrom
feat/map-v2.0.0

Conversation

@mrhoribu
Copy link
Contributor

@mrhoribu mrhoribu commented Jan 21, 2026

Important

Refactors map.lic into ElanthiaMap namespace with modular architecture, adds new features, and improves platform-specific GTK handling.

  • Refactor:
    • Complete refactor into ElanthiaMap namespace with module/class architecture.
    • Modernizes Ruby idioms and cleans up GTK3 code.
    • Renames legacy 'narost' variables to descriptive names.
  • Features:
    • Adds "Keep Centered" option to auto-center viewport on room marker.
    • Supports dynamic indicator size for room markers.
    • Adds comprehensive YARD documentation.
  • Platform-Specific Handling:
    • Special handling for macOS, Windows, and Linux/WSL+X11 in Window class.
    • Uses Quartz backend on macOS, Windows backend on native Windows, and X11/Wayland on Linux/WSL.
  • Settings and UI:
    • Adds new settings for dark mode, opacity, and scale management.
    • Implements a context menu with options for follow mode, keep centered, and more.
    • Provides reset functionality to restore default settings.
  • Miscellaneous:
    • Updates MapData class for metadata management.
    • Implements caching in MapCache class for map images.

This description was created by Ellipsis for c2ba439. You can customize this summary. It will automatically update as commits are pushed.

ellipsis-dev[bot]

This comment was marked as outdated.

@mrhoribu

This comment was marked as outdated.

ellipsis-dev[bot]

This comment was marked as outdated.

mrhoribu and others added 2 commits January 21, 2026 22:24
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@mrhoribu

This comment was marked as outdated.

ellipsis-dev[bot]

This comment was marked as outdated.

change from +28 to +32 pixel for macos
change global scale default from true back to false
change room indicator to be fixed size (58x58) with a new toggle for "dynamic indicator size" OFF by default
increase scale factor below 100% for dynamic indactor (2x to 5x)
add Char.name back to Map title bar
@mrhoribu mrhoribu marked this pull request as draft January 31, 2026 16:57
@mrhoribu mrhoribu marked this pull request as ready for review January 31, 2026 16:57
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to c2ba439 in 12 seconds. Click for details.
  • Reviewed 3241 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_ggefVfZNe1t2oOkw

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@OSXLich-Doug
Copy link
Contributor

Looks great! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants