Conversation
|
Hey, just added a few last-minute UI polishes and fixes I wanted to get in-
|
|
Hi @liraz747, I have a few minor bugs/design notes I would be glad to bring to your attention. Can you please address these?
Other than that, I think the new design is really nice and modern, and a very welcome change! Hopefully we can squash these bugs and merge it once the above points have been addressed. 🙏 Thanks again so much for the hard work you put into this! 🥇 |
I'm glad you like the design! :) I tried to address all the issues you mentioned: **UI Changes:** - Switched the **collapsing toolbar layout** for a standard TopAppBar/back to the action bar - Improved **title display** when clicking an alert - Fixed the **map showing cropped** - Fixed the **share button stuttering** when switching to map tab for a moment **Bug Fixes:** - Fixed the **map only loading on automatic map reload** and taking 10 seconds to load - Got **share button** back - Fixed the **restore button not showing** on the alerts list after clearing all alerts - Fixed the **"Select your city" popup** to redirect to the actual city selection dialog **Improvements:** - Added back a **loading indicator** on automatic map refreshes - Added an **animation for clearing and restoring** the recent alerts list :) - Implemented **asynchronous loading** for the map when going to the map tab (preventing delay when switching to it) - Added **predictive back animation** when switching between settings screens - Made the action bar title **immediately change back** to recent alerts when going back from an alert rather than waiting for animation to finish to make the app feel more responsive **Other:** - Updated to **TargetSdkVersion 35** I couldn't seem to reproduce the 2 clear recent alerts buttons appearing or the back button not working when viewing an individual alert - could you please check if it's working as expected for you now? :)
235e902 to
45d36cc
Compare
|
Hey @eladnava! I'm glad you like the design! :) I tried to address all the issues you mentioned: UI Changes:
Bug Fixes:
Improvements:
Other:
I couldn't seem to reproduce the 2 clear recent alerts buttons appearing or the back button not working when viewing an individual alert - could you please check if it's working as expected for you now? :) |
|
Hi @liraz747, I really like the new TopAppBar design, thanks for making that change so that the whitespace issue is addressed. The animations are great, and I think the app looks so much more modern now. I have a few more minor bugs that I would be glad to bring to your attention. Can you please address these?
For backwards compatibility, please ensure that all existing users of the app will be able to seamlessly update to this new version of the app (the existing SharedPreferences and their storage types have to be taken into account). Note: This also crashes in Secondary Alerts -> Volume Level. I can see that on a fresh install, this bug is not reproducible.
Only after switching back to the Recent Alerts tab and back to Settings does the app hide it. Please check whether the app becomes exempt from battery optimizations in the
The app should detect that the user just enabled the permission in device settings and auto-enable the Show Popup setting immediately (the
Tapping "Update Interval" & "Max Distance" settings leads to a crash (
Once all these can be resolved and the app is 100% functional, I will be glad to merge this PR and release an update. 🙏 Thanks again for your time and efforts! |








Material Design 3 UI Redesign
Hey @eladnava!
As discussed in issue #68, I have been working on modernizing the app UI to follow Material Design 3 guidelines. This has been such a fun (but also quite challenging!) project to work on, and I am really excited to share what I have come up with!
This is a pretty massive refactor - the app has been completely transformed while keeping all the core functionality intact.
Whats New
Core UI Overhaul
New Fragment-Based Architecture
Settings Revamp
Visual Improvements
Internationalization
Technical Improvements
Screenshots
(The screenshots from issue #68 show the new design)
Testing Notes
While I tried to thoroughly test the app with a mock server I connected it to, I was not able to test with the original API due to Firebase Installations (FIS) auth errors, Pushy authentication errors, and other auth errors with the RedAlert API during development. The core alert logic remains completely unchanged, so everything should work as expected once connected to the production servers.
Notes
Related Issue
Closes #68
Let me know if you have any questions or if theres anything youd like me to adjust! :)
Thanks for considering this contribution!