Allow user-defined structs as keys to the interval tree#31
Open
PankajBhojwani wants to merge 4 commits intoekg:masterfrom
Open
Allow user-defined structs as keys to the interval tree#31PankajBhojwani wants to merge 4 commits intoekg:masterfrom
PankajBhojwani wants to merge 4 commits intoekg:masterfrom
Conversation
DHowett
reviewed
Oct 1, 2020
DHowett
reviewed
Oct 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Thank you for this implementation - it is extremely useful!
I'd like to propose a change that would allow custom structs to be used as keys to the tree as long as those structs have the
<,<=,>,>=,==operators defined.The only code change this involves is instead of checking for equality with 0, we check for equality with the default constructor. For integral values, this does not change the behaviour.
UPDATE:
This also now adds a default constructor and the equality/inequality operators just for ease of use