-
Notifications
You must be signed in to change notification settings - Fork 1
⚠️ Feature: Adding the option to pull from a private repository #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4b90af7 to
f99d949
Compare
|
|
Skill Issue: |
|
Other git interface seem to need the authentication aswell. At least the Polling interface. |
5f51ecd to
c83c4b0
Compare
|
Reconcile + Redeployment still active. For testing purposes, in favor of improvements, the poll interval has been removed. I'll re-work the implementation within this pr. Overall, the implementation of pulling cdk8s deployment definition from a private repository, using a ssh token is working. Next up:
|
Implemented CheckAcess on reconciler
2fc651b to
66a46bc
Compare
|
The Poll Interval has been removed. We should re-work the reconciler as a whole. |
…sabled pollingInterval
|
I also commented the Git polling and Hashing implementation for now. Since we need to re-work the Poll Interval, we are save to keep this commented. |
RegWin32
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests looked fine, great code. LGTM
What this PR does / why we need it:
This PR introduces the first implementation for using a secretRef within our API to pull/clone from private repositories.
Which issue(s) this PR fixes:
Fixes #20