Skip to content

fix: resolve material map scripts for Acts 39 #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR addresses changes in the material map scripts for Acts 39.

What kind of change does this PR introduce?

  • Bug fix (issue: Acts 39 upgrade broke material map scripts)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc wdconinc requested a review from veprbl July 21, 2025 21:19
@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label Jul 21, 2025
@wdconinc wdconinc requested a review from rahmans1 July 21, 2025 21:19
veprbl
veprbl previously approved these changes Jul 21, 2025
@wdconinc wdconinc force-pushed the material-map-acts-39 branch from ccaa405 to 005a826 Compare July 22, 2025 18:52
@wdconinc
Copy link
Contributor Author

Material map validation failure bisected to acts-project/acts#3449

@github-actions github-actions bot added topic: barrel Mid-rapidity detectors topic: PID Particle identification labels Jul 23, 2025
@github-actions github-actions bot added topic: forward Positive-rapidity detectors (hadron-going side) topic: far-forward Deterctors for small-angle particles labels Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: barrel Mid-rapidity detectors topic: far-forward Deterctors for small-angle particles topic: forward Positive-rapidity detectors (hadron-going side) topic: infrastructure Regarding build system, CI, CD topic: PID Particle identification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants