Skip to content

Conversation

nathanwbrei
Copy link
Contributor

PR #1959 pulled in JANA2 v2.4.2's JOmniFactory and JOmniFactoryGenerator after JANA2 v2.4.3 was already released. The new release includes backwards incompatible changes to JOmniFactory{Generator}. They add support for multiple variadic inputs and outputs with arbitrary arity, which is needed for timeframe splitting.

@github-actions github-actions bot added topic: calorimetry relates to calorimetry topic: PID Relates to PID reconstruction topic: backward labels Aug 7, 2025
@nathanwbrei nathanwbrei marked this pull request as draft August 7, 2025 20:07
@wdconinc
Copy link
Contributor

wdconinc commented Aug 8, 2025

Sorry.... #2005

@nathanwbrei
Copy link
Contributor Author

#2005 makes my life easier actually, it gives me a chance to avoid some backwards compatibility headaches. Let's discuss what you need on your side in order to un-revert, because I have a couple of modifications as well

@wdconinc
Copy link
Contributor

wdconinc commented Aug 8, 2025

#2005 makes my life easier actually, it gives me a chance to avoid some backwards compatibility headaches.

It might not avoid the backwards compatibility headaches: in EICrecon we would still expect support from JANA 2.3.2 all the way up to the current version (and all version in between, unless you explicitly block a version from being used in the CMakeLists.txt).

Let's discuss what you need on your side in order to un-revert, because I have a couple of modifications as well

I am not sure yet what the cause of this issue is. It is (probably) something about how exceptions are treated differently, but I don't see yet where.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: backward topic: calorimetry relates to calorimetry topic: PID Relates to PID reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants