Tkuma timeframe splitting #1916
Open
+1,405
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JANA2 is moving away from the JEventSource(std::string resource_name, JApplication*) constructor because it doesn't play nicely with injected JApplications. Instead, we use the newer, simplified JEventSource constructor, and move the JEventSourcePODIO parameter registration out of the constructor and into the Init() callback where it anyhow belongs.
This is so that we can use CI to test that reconstruction isn't changed in the case when timeframe=physicsevent.
### Briefly, what does this PR introduce? 1. Implement simple time split algorithm in the timesplitter. 2. Create a new factory to align hit time. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [O] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [O] Tests for the changes have been added - [ ] Documentation has been added / updated - [O] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? ### Does this PR change default behavior? --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
github-actions
bot
added
topic: calorimetry
nathanwbrei
force-pushed
the
tkuma_timeframe_splitting
branch
from
04c7464 to
2edd9ca
Compare
nathanwbrei
force-pushed
the
tkuma_timeframe_splitting
branch
from
fe10348 to
e7a6762
Compare
nathanwbrei
had a problem deploying
to
github-pages
GitHub Actions
Failure
nathanwbrei
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?