#DRAFT adding charge sharing for ECTOF #1890
Open
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am taking dummy numbers for sigma_x and sigma_y for time being later these can be changed.
for more information, see https://pre-commit.ci
simonge
reviewed
Jun 3, 2025
There was a problem hiding this comment.
Thanks for your contribution, a couple of quick comments.
To make this compile you will need to include at the top of ECTOF.cc :
#include "factories/digi/SiliconChargeSharing_factory.h"
If you want to add the TOFEndcapSharedHits to the default output you'll need to add them to the list here:
https://github.com/eic/EICrecon/blob/main/src/services/io/podio/JEventProcessorPODIO.cc#L79
|
Thank you @simonge , it worked for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Adding charge sharing for ECTOF
I am taking dummy numbers for sigma_x and sigma_y for time being later these can be changed.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?